Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1326)

Unified Diff: content/renderer/pepper/content_decryptor_delegate.cc

Issue 515753002: Verify promise type before casting. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 6 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | media/base/cdm_promise.h » ('j') | media/base/cdm_promise.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: content/renderer/pepper/content_decryptor_delegate.cc
diff --git a/content/renderer/pepper/content_decryptor_delegate.cc b/content/renderer/pepper/content_decryptor_delegate.cc
index e1b0b1ba3e5d1100275908abf15dd578ec1b86a9..3d8bc0156150c55fa1f3bc8e53e4a6fcb23dbfd4 100644
--- a/content/renderer/pepper/content_decryptor_delegate.cc
+++ b/content/renderer/pepper/content_decryptor_delegate.cc
@@ -625,7 +625,10 @@ bool ContentDecryptorDelegate::DecryptAndDecodeVideo(
void ContentDecryptorDelegate::OnPromiseResolved(uint32 promise_id) {
scoped_ptr<CdmPromise> promise = TakePromise(promise_id);
- if (promise) {
+ DCHECK(promise &&
+ promise->GetResolveParameterType() == media::CdmPromise::VOID_TYPE);
+ if (promise &&
+ promise->GetResolveParameterType() == media::CdmPromise::VOID_TYPE) {
SimpleCdmPromise* simple_promise(
static_cast<SimpleCdmPromise*>(promise.get()));
simple_promise->resolve();
@@ -640,7 +643,10 @@ void ContentDecryptorDelegate::OnPromiseResolvedWithSession(
StringVar* web_session_id_string = StringVar::FromPPVar(web_session_id);
DCHECK(web_session_id_string);
- if (promise) {
+ DCHECK(promise &&
+ promise->GetResolveParameterType() == media::CdmPromise::STRING_TYPE);
+ if (promise &&
+ promise->GetResolveParameterType() == media::CdmPromise::STRING_TYPE) {
xhwang 2014/08/27 22:49:26 ditto
jrummell 2014/08/27 23:05:13 Done.
NewSessionCdmPromise* session_promise(
static_cast<NewSessionCdmPromise*>(promise.get()));
session_promise->resolve(web_session_id_string->value());
« no previous file with comments | « no previous file | media/base/cdm_promise.h » ('j') | media/base/cdm_promise.h » ('J')

Powered by Google App Engine
This is Rietveld 408576698