Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(536)

Unified Diff: pkg/analysis_server/test/services/refactoring/inline_local_test.dart

Issue 515733002: 'Inline Local' refactoring. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Created 6 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: pkg/analysis_server/test/services/refactoring/inline_local_test.dart
diff --git a/pkg/analysis_server/test/services/refactoring/inline_local_test.dart b/pkg/analysis_server/test/services/refactoring/inline_local_test.dart
new file mode 100644
index 0000000000000000000000000000000000000000..fad316412de0fe64f79d765c7e408ef59a0b18a4
--- /dev/null
+++ b/pkg/analysis_server/test/services/refactoring/inline_local_test.dart
@@ -0,0 +1,264 @@
+// Copyright (c) 2014, the Dart project authors. Please see the AUTHORS file
+// for details. All rights reserved. Use of this source code is governed by a
+// BSD-style license that can be found in the LICENSE file.
+
+library test.services.refactoring.inline_local;
+
+import 'package:analysis_server/src/protocol.dart' hide Element;
+import 'package:analysis_server/src/services/refactoring/inline_local.dart';
+import 'package:analysis_server/src/services/refactoring/refactoring.dart';
+import 'package:analysis_testing/reflective_tests.dart';
+import 'package:analyzer/src/generated/ast.dart';
+import 'package:analyzer/src/generated/element.dart';
+import 'package:unittest/unittest.dart';
+
+import 'abstract_refactoring.dart';
+
+
+main() {
+ groupSep = ' | ';
+ runReflectiveTests(InlineLocalTest);
+}
+
+
+@ReflectiveTestCase()
+class InlineLocalTest extends RefactoringTest {
+ InlineLocalRefactoringImpl refactoring;
+
+ test_OK_cascade_intoCascade() {
+ indexTestUnit(r'''
+class A {
+ foo() {}
+ bar() {}
+}
+main() {
+ A test = new A()..foo();
+ test..bar();
+}
+''');
+ _createRefactoring('test =');
+ // validate change
+ return assertSuccessfulRefactoring(r'''
+class A {
+ foo() {}
+ bar() {}
+}
+main() {
+ new A()..foo()..bar();
+}
+''');
+ }
+
+ test_OK_cascade_intoNotCascade() {
+ indexTestUnit(r'''
+class A {
+ foo() {}
+ bar() {}
+}
+main() {
+ A test = new A()..foo();
+ test.bar();
+}
+''');
+ _createRefactoring('test =');
+ // validate change
+ return assertSuccessfulRefactoring(r'''
+class A {
+ foo() {}
+ bar() {}
+}
+main() {
+ (new A()..foo()).bar();
+}
+''');
+ }
+
+ test_OK_intoStringInterpolation() {
+ indexTestUnit(r'''
+main() {
+ int test = 1 + 2;
+ print('test = $test');
+ print('test = ${test}');
+ print('test = ${process(test)}');
+}
+process(x) {}
+''');
+ _createRefactoring('test =');
+ // validate change
+ return assertSuccessfulRefactoring(r'''
+main() {
+ print('test = ${1 + 2}');
+ print('test = ${1 + 2}');
+ print('test = ${process(1 + 2)}');
+}
+process(x) {}
+''');
+ }
+
+ /**
+ * <p>
+ * https://code.google.com/p/dart/issues/detail?id=18587
+ */
+ test_OK_keepNextCommentedLine() {
+ indexTestUnit('''
+main() {
+ int test = 1 + 2;
+ // foo
+ print(test);
+ // bar
+}
+''');
+ _createRefactoring('test =');
+ // validate change
+ return assertSuccessfulRefactoring('''
+main() {
+ // foo
+ print(1 + 2);
+ // bar
+}
+''');
+ }
+
+ test_OK_noUsages_1() {
+ indexTestUnit('''
+main() {
+ int test = 1 + 2;
+ print(0);
+}
+''');
+ _createRefactoring('test =');
+ // validate change
+ return assertSuccessfulRefactoring('''
+main() {
+ print(0);
+}
+''');
+ }
+
+ test_OK_noUsages_2() {
+ indexTestUnit('''
+main() {
+ int test = 1 + 2;
+}
+''');
+ _createRefactoring('test =');
+ // validate change
+ return assertSuccessfulRefactoring('''
+main() {
+}
+''');
+ }
+
+ test_OK_oneUsage() {
+ indexTestUnit('''
+main() {
+ int test = 1 + 2;
+ print(test);
+}
+''');
+ _createRefactoring('test =');
+ // validate change
+ return assertSuccessfulRefactoring('''
+main() {
+ print(1 + 2);
+}
+''');
+ }
+
+ test_OK_twoUsages() {
+ indexTestUnit('''
+main() {
+ int test = 1 + 2;
+ print(test);
+ print(test);
+}
+''');
+ _createRefactoring('test =');
+ // validate change
+ return assertSuccessfulRefactoring('''
+main() {
+ print(1 + 2);
+ print(1 + 2);
+}
+''');
+ }
+
+ test_access() {
+ indexTestUnit('''
+main() {
+ int test = 1 + 2;
+ print(test);
+ print(test);
+}
+''');
+ _createRefactoring('test =');
+ expect(refactoring.refactoringName, 'Inline Local Variable');
+ // check initial conditions and access
+ return refactoring.checkInitialConditions().then((_) {
+ expect(refactoring.referenceCount, 2);
+ });
+ }
+
+ test_bad_selectionVariable_hasAssignments_1() {
+ indexTestUnit(r'''
+main() {
+ int test = 0;
+ test = 1;
+}
+''');
+ _createRefactoring('test = 0');
+ return refactoring.checkInitialConditions().then((status) {
+ assertRefactoringStatus(
+ status,
+ RefactoringProblemSeverity.FATAL,
+ expectedContextSearch: 'test = 1');
+ });
+ }
+
+ test_bad_selectionVariable_hasAssignments_2() {
+ indexTestUnit(r'''
+main() {
+ int test = 0;
+ test += 1;
+}
+''');
+ _createRefactoring('test = 0');
+ return refactoring.checkInitialConditions().then((status) {
+ assertRefactoringStatus(
+ status,
+ RefactoringProblemSeverity.FATAL,
+ expectedContextSearch: 'test += 1');
+ });
+ }
+
+ test_bad_selectionVariable_notInBlock() {
+ indexTestUnit(r'''
+main() {
+ if (true)
+ int test = 0;
+}
+''');
+ _createRefactoring('test = 0');
+ return refactoring.checkInitialConditions().then((status) {
+ assertRefactoringStatus(status, RefactoringProblemSeverity.FATAL);
+ });
+ }
+
+ test_bad_selectionVariable_notInitialized() {
+ indexTestUnit(r'''
+main() {
+ int test;
+}
+''');
+ _createRefactoring('test;');
+ return refactoring.checkInitialConditions().then((status) {
+ assertRefactoringStatus(status, RefactoringProblemSeverity.FATAL);
+ });
+ }
+
+ void _createRefactoring(String search) {
+ SimpleIdentifier identifier = findIdentifier(search);
+ LocalVariableElement element = identifier.bestElement;
+ refactoring = new InlineLocalRefactoring(searchEngine, testUnit, element);
+ }
+}

Powered by Google App Engine
This is Rietveld 408576698