Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(462)

Issue 515723005: Make a few fixes to the ChromeVox webstore upload script. (Closed)

Created:
6 years, 3 months ago by David Tseng
Modified:
6 years, 3 months ago
Reviewers:
dmazzoni
CC:
chromium-reviews, oshima+watch_chromium.org, plundblad+watch_chromium.org, aboxhall+watch_chromium.org, nkostylev+watch_chromium.org, yuzo+watch_chromium.org, dmazzoni+watch_chromium.org, dtseng+watch_chromium.org, stevenjb+watch_chromium.org, arv+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Make a few fixes to the ChromeVox webstore upload script. TEST=run the script: enter 'u' to upload, login and verify that uploading is successful. Back at the prompt, enter 'p' to publish publically. Verify ChromeVox updates. Committed: https://crrev.com/2c8ed7375216b30f5a30cd57b5a87904618351a8 Cr-Commit-Position: refs/heads/master@{#293784}

Patch Set 1 : #

Patch Set 2 : #

Patch Set 3 : #

Patch Set 4 : #

Total comments: 2

Patch Set 5 : bufsize=0 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+20 lines, -12 lines) Patch
M chrome/browser/resources/chromeos/chromevox/tools/chromevox_webstore_util.py View 1 2 3 2 chunks +2 lines, -1 line 0 comments Download
M chrome/browser/resources/chromeos/chromevox/tools/upload_chromevox_to_webstore.py View 1 2 3 4 4 chunks +18 lines, -11 lines 0 comments Download

Messages

Total messages: 16 (3 generated)
David Tseng
Patchset #1 (id:1) has been deleted
6 years, 3 months ago (2014-08-28 20:07:58 UTC) #1
David Tseng
Ready for review. Just used this to make a webstore release of ChromeVox (39.0.2139.0) which ...
6 years, 3 months ago (2014-08-28 23:06:24 UTC) #2
David Tseng
dtseng@chromium.org changed reviewers: + dmazzoni@chromium.org
6 years, 3 months ago (2014-08-28 23:07:57 UTC) #3
David Tseng
6 years, 3 months ago (2014-08-28 23:08:05 UTC) #4
dmazzoni
https://codereview.chromium.org/515723005/diff/80001/chrome/browser/resources/chromeos/chromevox/tools/upload_chromevox_to_webstore.py File chrome/browser/resources/chromeos/chromevox/tools/upload_chromevox_to_webstore.py (right): https://codereview.chromium.org/515723005/diff/80001/chrome/browser/resources/chromeos/chromevox/tools/upload_chromevox_to_webstore.py#newcode52 chrome/browser/resources/chromeos/chromevox/tools/upload_chromevox_to_webstore.py:52: new_file.file.flush() As an alternative to calling flush, pass bufsize ...
6 years, 3 months ago (2014-08-28 23:13:01 UTC) #5
David Tseng
https://codereview.chromium.org/515723005/diff/80001/chrome/browser/resources/chromeos/chromevox/tools/upload_chromevox_to_webstore.py File chrome/browser/resources/chromeos/chromevox/tools/upload_chromevox_to_webstore.py (right): https://codereview.chromium.org/515723005/diff/80001/chrome/browser/resources/chromeos/chromevox/tools/upload_chromevox_to_webstore.py#newcode52 chrome/browser/resources/chromeos/chromevox/tools/upload_chromevox_to_webstore.py:52: new_file.file.flush() On 2014/08/28 23:13:01, dmazzoni wrote: > As an ...
6 years, 3 months ago (2014-08-29 21:12:49 UTC) #6
David Tseng
Friendly ping.
6 years, 3 months ago (2014-09-03 23:39:32 UTC) #7
dmazzoni
lgtm
6 years, 3 months ago (2014-09-04 15:45:27 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/dtseng@chromium.org/515723005/100001
6 years, 3 months ago (2014-09-04 16:30:52 UTC) #10
commit-bot: I haz the power
Try jobs failed on following builders: win_gpu_triggered_tests on tryserver.chromium.gpu (http://build.chromium.org/p/tryserver.chromium.gpu/builders/win_gpu_triggered_tests/builds/47852)
6 years, 3 months ago (2014-09-04 19:10:27 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/dtseng@chromium.org/515723005/100001
6 years, 3 months ago (2014-09-08 20:45:11 UTC) #14
commit-bot: I haz the power
Committed patchset #5 (id:100001) as d38672c5e88f028ebf6f1d7d380bfeef080f2be2
6 years, 3 months ago (2014-09-08 20:51:07 UTC) #15
commit-bot: I haz the power
6 years, 3 months ago (2014-09-10 03:48:08 UTC) #16
Message was sent while issue was closed.
Patchset 5 (id:??) landed as
https://crrev.com/2c8ed7375216b30f5a30cd57b5a87904618351a8
Cr-Commit-Position: refs/heads/master@{#293784}

Powered by Google App Engine
This is Rietveld 408576698