Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(294)

Issue 515723004: Deoptimize context value in Turbofan (and Crankshaft). (Closed)

Created:
6 years, 3 months ago by Jarin
Modified:
6 years, 3 months ago
Reviewers:
Michael Starzinger
CC:
v8-dev
Project:
v8
Visibility:
Public.

Description

Deoptimize context value in Turbofan (and Crankshaft). The CL also threads through the context value from the deoptimizer to the debugger (GetFrameDetails and DebugEvaluate runtime functions). BUG=

Patch Set 1 #

Patch Set 2 : Fix tests. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+120 lines, -85 lines) Patch
M src/arm/lithium-arm.cc View 1 chunk +1 line, -0 lines 0 comments Download
M src/arm64/lithium-arm64.cc View 1 chunk +1 line, -0 lines 0 comments Download
M src/compiler/ast-graph-builder.cc View 1 chunk +2 lines, -1 line 0 comments Download
M src/compiler/common-operator.h View 1 chunk +1 line, -1 line 0 comments Download
M src/compiler/graph-builder.h View 2 chunks +3 lines, -0 lines 0 comments Download
M src/compiler/instruction.h View 1 chunk +4 lines, -1 line 0 comments Download
M src/compiler/instruction-selector.cc View 2 chunks +6 lines, -0 lines 0 comments Download
M src/deoptimizer.h View 2 chunks +4 lines, -0 lines 0 comments Download
M src/deoptimizer.cc View 1 4 chunks +9 lines, -7 lines 0 comments Download
M src/hydrogen.cc View 1 chunk +2 lines, -3 lines 0 comments Download
M src/hydrogen-instructions.h View 4 chunks +15 lines, -19 lines 0 comments Download
M src/ia32/lithium-ia32.cc View 2 chunks +3 lines, -3 lines 0 comments Download
M src/lithium.cc View 2 chunks +14 lines, -8 lines 0 comments Download
M src/mips/lithium-mips.cc View 1 chunk +1 line, -0 lines 0 comments Download
M src/mips64/lithium-mips64.cc View 1 chunk +1 line, -0 lines 0 comments Download
M src/runtime.cc View 3 chunks +5 lines, -2 lines 0 comments Download
M src/x64/lithium-x64.cc View 2 chunks +3 lines, -3 lines 0 comments Download
M src/x87/lithium-x87.cc View 1 chunk +1 line, -0 lines 0 comments Download
M test/cctest/compiler/test-codegen-deopt.cc View 1 2 chunks +4 lines, -4 lines 0 comments Download
M test/cctest/compiler/test-scheduler.cc View 1 chunk +2 lines, -1 line 0 comments Download
M test/compiler-unittests/instruction-selector-unittest.cc View 6 chunks +23 lines, -17 lines 0 comments Download
M test/mjsunit/debug-clearbreakpointgroup.js View 1 chunk +1 line, -0 lines 0 comments Download
M test/mjsunit/debug-evaluate-closure.js View 1 chunk +1 line, -0 lines 0 comments Download
M test/mjsunit/debug-evaluate-with.js View 1 chunk +2 lines, -0 lines 0 comments Download
M test/mjsunit/debug-step-2.js View 1 chunk +1 line, -0 lines 0 comments Download
M test/mjsunit/mjsunit.status View 2 chunks +0 lines, -15 lines 0 comments Download
M test/mjsunit/regress/regress-1170187.js View 1 chunk +2 lines, -0 lines 0 comments Download
M test/mjsunit/regress/regress-119609.js View 1 chunk +1 line, -0 lines 0 comments Download
M test/mjsunit/regress/regress-131994.js View 1 chunk +1 line, -0 lines 0 comments Download
M test/mjsunit/regress/regress-325676.js View 1 chunk +1 line, -0 lines 0 comments Download
M test/mjsunit/regress/regress-crbug-107996.js View 1 chunk +1 line, -0 lines 0 comments Download
M test/mjsunit/regress/regress-crbug-171715.js View 1 chunk +1 line, -0 lines 0 comments Download
M test/mjsunit/regress/regress-crbug-222893.js View 1 chunk +1 line, -0 lines 0 comments Download
M test/mjsunit/regress/regress-debug-deopt-while-recompile.js View 1 chunk +1 line, -0 lines 0 comments Download
M test/mjsunit/regress/regress-opt-after-debug-deopt.js View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
Jarin
jarin@chromium.org changed reviewers: + mstarzinger@chromium.org
6 years, 3 months ago (2014-08-28 15:16:37 UTC) #1
Jarin
Could you take a look, please?
6 years, 3 months ago (2014-08-28 15:16:54 UTC) #2
Jarin
6 years, 3 months ago (2014-08-29 14:53:43 UTC) #3
On 2014/08/28 15:16:54, jarin wrote:
> Could you take a look, please?

ping.

Powered by Google App Engine
This is Rietveld 408576698