Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(247)

Issue 515723003: Shows the static logo image in athena home card. (Closed)

Created:
6 years, 3 months ago by Jun Mukai
Modified:
6 years, 3 months ago
Reviewers:
tony, oshima
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Shows the static logo image in athena home card. This CL depends on https://codereview.chromium.org/512943003/ BUG=408373 R=oshima@chromium.org TBR=tony@chromium.org TEST=manually Committed: https://crrev.com/7e481016a8ba3036940f0274071a13a7895711eb Cr-Commit-Position: refs/heads/master@{#292335}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+15 lines, -28 lines) Patch
M athena/home/DEPS View 1 chunk +2 lines, -0 lines 0 comments Download
M athena/home/app_list_view_delegate.cc View 2 chunks +11 lines, -27 lines 0 comments Download
M athena/home/athena_start_page_view.cc View 1 chunk +2 lines, -1 line 0 comments Download

Messages

Total messages: 14 (0 generated)
Jun Mukai
6 years, 3 months ago (2014-08-27 23:50:25 UTC) #1
oshima
lgtm can you also fix grit include in athena/main/placeholder.cc (in separate CL)? you may tbr
6 years, 3 months ago (2014-08-28 00:13:57 UTC) #2
Jun Mukai
On 2014/08/28 00:13:57, oshima wrote: > lgtm > > can you also fix grit include ...
6 years, 3 months ago (2014-08-28 00:21:24 UTC) #3
Jun Mukai
The CQ bit was checked by mukai@chromium.org
6 years, 3 months ago (2014-08-28 00:59:41 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/mukai@chromium.org/515723003/1
6 years, 3 months ago (2014-08-28 01:03:56 UTC) #5
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: chromium_presubmit on tryserver.chromium.linux ...
6 years, 3 months ago (2014-08-28 01:59:01 UTC) #6
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 3 months ago (2014-08-28 02:03:02 UTC) #7
commit-bot: I haz the power
Try jobs failed on following builders: chromium_presubmit on tryserver.chromium.linux (http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presubmit/builds/7214)
6 years, 3 months ago (2014-08-28 02:03:03 UTC) #8
Jun Mukai
mukai@chromium.org changed reviewers: + tony@chromium.org
6 years, 3 months ago (2014-08-28 06:50:56 UTC) #9
Jun Mukai
TBR=tony for new dependency of ui/base/resource
6 years, 3 months ago (2014-08-28 06:51:10 UTC) #10
Jun Mukai
The CQ bit was checked by mukai@chromium.org
6 years, 3 months ago (2014-08-28 06:51:13 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/mukai@chromium.org/515723003/1
6 years, 3 months ago (2014-08-28 06:51:45 UTC) #12
commit-bot: I haz the power
Committed patchset #1 (id:1) as e15fc9d9a9c150d8ac8e58942532b6f8e57cb5f3
6 years, 3 months ago (2014-08-28 06:57:11 UTC) #13
commit-bot: I haz the power
6 years, 3 months ago (2014-09-10 02:58:02 UTC) #14
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/7e481016a8ba3036940f0274071a13a7895711eb
Cr-Commit-Position: refs/heads/master@{#292335}

Powered by Google App Engine
This is Rietveld 408576698