Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(237)

Issue 515593004: DevTools: Restore embedded devtools manager unit test checks after switching service worker inspect… (Closed)

Created:
6 years, 3 months ago by vsevik
Modified:
6 years, 3 months ago
Reviewers:
yurys, horo
CC:
chromium-reviews, vsevik, jam, yurys, paulirish+reviews_chromium.org, darin-cc_chromium.org, devtools-reviews_chromium.org, aandrey+blink_chromium.org, pfeldman
Base URL:
https://chromium.googlesource.com/chromium/src.git@serviceworkers
Project:
chromium
Visibility:
Public.

Description

DevTools: Restore embedded devtools manager unit test checks after switching service worker inspection on the main thread. TBR=yurys, horo BUG=404355 Committed: https://crrev.com/0010604872a581f795e079b62f2c2376661a88ea Cr-Commit-Position: refs/heads/master@{#292415}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -0 lines) Patch
M content/browser/devtools/embedded_worker_devtools_manager_unittest.cc View 6 chunks +6 lines, -0 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
vsevik
The CQ bit was checked by vsevik@chromium.org
6 years, 3 months ago (2014-08-28 15:59:55 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/vsevik@chromium.org/515593004/1
6 years, 3 months ago (2014-08-28 16:00:47 UTC) #2
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: mac_gpu on tryserver.chromium.gpu ...
6 years, 3 months ago (2014-08-28 16:55:56 UTC) #3
commit-bot: I haz the power
Committed patchset #1 (id:1) as e00257a43893511b0e9ce580402b860e024c7f6a
6 years, 3 months ago (2014-08-28 18:20:06 UTC) #4
horo
lgtm
6 years, 3 months ago (2014-08-29 02:19:07 UTC) #5
commit-bot: I haz the power
6 years, 3 months ago (2014-09-10 03:00:37 UTC) #6
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/0010604872a581f795e079b62f2c2376661a88ea
Cr-Commit-Position: refs/heads/master@{#292415}

Powered by Google App Engine
This is Rietveld 408576698