Source/core/timing/Performance.cpp - Issue 515583005: Add ServiceWorker timing information on the popup panel in DevTools's Network tab (1/2)

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/core/timing/Performance.cpp

Issue 515583005: Add ServiceWorker timing information on the popup panel in DevTools's Network tab (1/2) (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Incorporate the review Created 6 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « Source/core/inspector/InspectorResourceAgent.cpp ('k') | Source/devtools/front_end/network/RequestTimingView.js » ('j') | Source/devtools/front_end/network/RequestTimingView.js » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: Source/core/timing/Performance.cpp

diff --git a/Source/core/timing/Performance.cpp b/Source/core/timing/Performance.cpp

index 4a5c18cc528b9ccf8013639955b07b5a0a69cee9..71f945f7b3afadd454ce7bee1ef3a5e64ca30ff6 100644

--- a/Source/core/timing/Performance.cpp

+++ b/Source/core/timing/Performance.cpp

@@ -214,9 +214,7 @@ void Performance::addResourceTiming(const ResourceTimingInfo& info, Document* in

const Vector<ResourceResponse>& redirectChain = info.redirectChain();

bool allowRedirectDetails = allowsTimingRedirect(redirectChain, finalResponse, initiatorDocument);

- // ServiceWorker doesn't support TimingInfo.

- // FIXME: Implement ServiceWorkerURLRequestJob::GetLoadTimingInfo().

- if (!allowRedirectDetails && !finalResponse.wasFetchedViaServiceWorker()) {

+ if (!allowRedirectDetails) {

ResourceLoadTiming* finalTiming = finalResponse.resourceLoadTiming();

ASSERT(finalTiming);

if (finalTiming)