Add ServiceWorker timing information on the popup panel in DevTools's Network tab (1/2)

Source/devtools/front_end/network/RequestTimingView.js

 /*
  * Copyright (C) 2010 Google Inc. All rights reserved.
  *
  * Redistribution and use in source and binary forms, with or without
  * modification, are permitted provided that the following conditions are
  * met:
  *
  *     * Redistributions of source code must retain the above copyright
  * notice, this list of conditions and the following disclaimer.
  *     * Redistributions in binary form must reproduce the above
@@ skipping 119 matching lines @@
         }
         return undefined;
     }
 
     var timing = request.timing;
     var blocking = firstPositive([timing.dnsStart, timing.connectStart, timing.sendStart]);
     var endTime = firstPositive([request.endTime, request.responseReceivedTime, timing.requestTime]);
     var total = (endTime - timing.requestTime) * 1000;
     const chartWidth = 200;
     var scale = chartWidth / total;
+    var createCommunicationTimingTable = function() {
+        if (blocking > 0)
+            addRow(WebInspector.UIString("Stalled"), "blocking", 0, blocking);
 
-    if (blocking > 0)
-        addRow(WebInspector.UIString("Stalled"), "blocking", 0, blocking);
+        if (timing.proxyStart !== -1)
+            addRow(WebInspector.UIString("Proxy negotiation"), "proxy", timing.proxyStart, timing.proxyEnd);
 
-    if (timing.proxyStart !== -1)
-        addRow(WebInspector.UIString("Proxy negotiation"), "proxy", timing.proxyStart, timing.proxyEnd);
+        if (timing.dnsStart !== -1)
+            addRow(WebInspector.UIString("DNS Lookup"), "dns", timing.dnsStart, timing.dnsEnd);
 
-    if (timing.dnsStart !== -1)
-        addRow(WebInspector.UIString("DNS Lookup"), "dns", timing.dnsStart, timing.dnsEnd);
+        if (timing.connectStart !== -1)
+            addRow(WebInspector.UIString("Initial connection"), "connecting", timing.connectStart, timing.connectEnd);
 
-    if (timing.connectStart !== -1)
-        addRow(WebInspector.UIString("Initial connection"), "connecting", timing.connectStart, timing.connectEnd);
+        if (timing.sslStart !== -1)
+            addRow(WebInspector.UIString("SSL"), "ssl", timing.sslStart, timing.sslEnd);
 
-    if (timing.sslStart !== -1)
-        addRow(WebInspector.UIString("SSL"), "ssl", timing.sslStart, timing.sslEnd);
+        addRow(WebInspector.UIString("Request sent"), "sending", timing.sendStart, timing.sendEnd);
+        addRow(WebInspector.UIString("Waiting (TTFB)"), "waiting", timing.sendEnd, timing.receiveHeadersEnd);
 
-    addRow(WebInspector.UIString("Request sent"), "sending", timing.sendStart, timing.sendEnd);
-    addRow(WebInspector.UIString("Waiting (TTFB)"), "waiting", timing.sendEnd, timing.receiveHeadersEnd);
+        if (request.endTime !== -1)
+            addRow(WebInspector.UIString("Content Download"), "receiving", (request.responseReceivedTime - timing.requestTime) * 1000, total);
 
-    if (request.endTime !== -1)
-        addRow(WebInspector.UIString("Content Download"), "receiving", (request.responseReceivedTime - timing.requestTime) * 1000, total);
+        if (!request.finished) {
+            var cell = tableElement.createChild("tr").createChild("td", "caution");
+            cell.colSpan = 2;
+            cell.createTextChild(WebInspector.UIString("CAUTION: request is not finished yet!"));
+        }
+    };
+    var createServiceWorkerTimingTable = function() {
+        addRow(WebInspector.UIString("Stalled"), "blocking", 0, timing.fetchStart);
 
-    if (!request.finished) {
-        var cell = tableElement.createChild("tr").createChild("td", "caution");
-        cell.colSpan = 2;
-        cell.createTextChild(WebInspector.UIString("CAUTION: request is not finished yet!"));
-    }
+        addRow(WebInspector.UIString("Request to ServiceWorker"), "connecting", timing.fetchStart, timing.fetchEnd);
+        addRow(WebInspector.UIString("Launching ServiceWorker"), "ssl", timing.fetchStart, timing.launchServiceWorker);
+        addRow(WebInspector.UIString("Waiting (TTFB)"), "waiting", timing.fetchEnd, timing.receiveHeadersEnd);
+
+        if (request.endTime !== -1)
+            addRow(WebInspector.UIString("Content Download"), "receiving", (request.responseReceivedTime - timing.requestTime) * 1000, total);
+
+        if (!request.finished) {
+            var cell = tableElement.createChild("tr").createChild("td", "caution");
+            cell.colSpan = 2;
+            cell.createTextChild(WebInspector.UIString("CAUTION: request is not finished yet!"));
+        }
+    };
+
+    if (request.fetchedViaServiceWorker)
+        createServiceWorkerTimingTable();

[eustas, 2014/08/28 06:23:30]

Please inline create###TimingTable()

[shimazu, 2014/08/28 07:11:19]

Sure, but I think this is more readable and extensible. Are there any rules?
On 2014/08/28 06:23:30, eustas wrote:

[eustas, 2014/08/28 07:32:01]

We have no strict rules, but ve do not use var-functions until is is absolutely
necessary.

Alternatively, you can extract those functions as member functions.
Let them return array of objects describing rows.

[pfeldman, 2014/08/28 07:35:04]

We do have a strict rule to not use anonymous functions (which implies that var
is prohibited).

[shimazu, 2014/08/29 02:00:46]

Done.

+    else
+        createCommunicationTimingTable();
 
     return tableElement;
 }