app_shell: Do simple audio initialization.

extensions/shell/browser/shell_audio_controller_chromeos_unittest.cc

Index: extensions/shell/browser/shell_audio_controller_chromeos_unittest.cc
diff --git a/extensions/shell/browser/shell_audio_controller_chromeos_unittest.cc b/extensions/shell/browser/shell_audio_controller_chromeos_unittest.cc
new file mode 100644
index 0000000000000000000000000000000000000000..01dd3efc0e910155647dae319428d8ae3b5cdbfb
--- /dev/null
+++ b/extensions/shell/browser/shell_audio_controller_chromeos_unittest.cc
@@ -0,0 +1,127 @@
+// Copyright 2014 The Chromium Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+#include "extensions/shell/browser/shell_audio_controller_chromeos.h"
+
+#include "base/macros.h"
+#include "chromeos/audio/audio_device.h"
+#include "chromeos/audio/cras_audio_handler.h"
+#include "chromeos/dbus/audio_node.h"
+#include "chromeos/dbus/cras_audio_client_stub_impl.h"
+#include "chromeos/dbus/dbus_thread_manager.h"
+#include "testing/gtest/include/gtest/gtest.h"
+
+namespace extensions {
+
+class ShellAudioControllerTest : public testing::Test {
+ public:
+  ShellAudioControllerTest() : next_node_id_(1) {
+    audio_client_ = new chromeos::CrasAudioClientStubImpl();
+    audio_client_->SetAudioDevices(chromeos::AudioNodeList());
+    chromeos::DBusThreadManager::GetSetterForTesting()->SetCrasAudioClient(
+        make_scoped_ptr(audio_client_).PassAs<chromeos::CrasAudioClient>());
+
+    chromeos::CrasAudioHandler::Initialize(
+        new ShellAudioController::PrefHandler());
+    audio_handler_ = chromeos::CrasAudioHandler::Get();
+
+    controller_.reset(new ShellAudioController());
+  }
+
+  virtual ~ShellAudioControllerTest() {
+    controller_.reset();
+    chromeos::CrasAudioHandler::Shutdown();
+    chromeos::DBusThreadManager::Shutdown();

[James Cook, 2014/08/28 18:48:37]

Just to double-check since I'm not familiar with this code: We need an explicit
DBusThreadManager::Shutdown() but not a DBusThreadManager::Initialize() or
InitializeForTesting()?

[Daniel Erat, 2014/08/28 23:27:57]

(discussed in person:) looks like it. i'll double-check that this is intentional
with zel when he's back at his desk (i think that he's the one who updated the
code that i copy-and-pasted here), but i've added comments here and in
DBusThreadManager for now.

+  }
+
+ protected:
+  // Fills a chromeos::AudioNode for use by tests.
+  chromeos::AudioNode CreateNode(chromeos::AudioDeviceType type) {
+    chromeos::AudioNode node;
+    node.is_input =
+        type == chromeos::AUDIO_TYPE_MIC ||
+        type == chromeos::AUDIO_TYPE_INTERNAL_MIC ||
+        type == chromeos::AUDIO_TYPE_KEYBOARD_MIC;
+    node.id = next_node_id_++;
+    node.type = chromeos::AudioDevice::GetTypeString(type);
+    return node;
+  }
+
+  // Changes the active state of the node with |id| in |nodes|.
+  void SetNodeActive(chromeos::AudioNodeList* nodes, uint64 id, bool active) {
+    for (chromeos::AudioNodeList::iterator it = nodes->begin();
+         it != nodes->end(); ++it) {
+      if (it->id == id) {
+        it->active = active;
+        return;
+      }
+    }
+    ASSERT_TRUE(false) << "Didn't find ID " << id;
+  }
+
+  chromeos::CrasAudioClientStubImpl* audio_client_;  // Not owned.
+  chromeos::CrasAudioHandler* audio_handler_;  // Not owned.
+  scoped_ptr<ShellAudioController> controller_;
+
+  // Next audio node ID to be returned by CreateNode().
+  uint64 next_node_id_;
+
+ private:
+  DISALLOW_COPY_AND_ASSIGN(ShellAudioControllerTest);
+};
+
+// Tests that higher-priority devices are activated as soon as they're
+// connected.
+TEST_F(ShellAudioControllerTest, SelectBestDevices) {
+  chromeos::AudioNode internal_speaker =

[James Cook, 2014/08/28 18:48:37]

optional: using chromeos::AudioNode and/or AudioNodeList might improve
readability

[Daniel Erat, 2014/08/28 23:27:57]

done (note to self: james is a reviewer who's okay with using-directives)

+      CreateNode(chromeos::AUDIO_TYPE_INTERNAL_SPEAKER);
+  chromeos::AudioNode internal_mic =
+      CreateNode(chromeos::AUDIO_TYPE_INTERNAL_MIC);
+  chromeos::AudioNode headphone = CreateNode(chromeos::AUDIO_TYPE_HEADPHONE);
+  chromeos::AudioNode external_mic = CreateNode(chromeos::AUDIO_TYPE_MIC);
+
+  // chromeos::AudioDevice gives the headphone jack a higher priority than the
+  // internal speaker and an external mic a higher priority than the internal
+  // mic, so we should start out favoring headphones and the external mic.

[James Cook, 2014/08/28 18:48:37]

nice per-block documentation

+  chromeos::AudioNodeList all_nodes;
+  all_nodes.push_back(internal_speaker);
+  all_nodes.push_back(internal_mic);
+  all_nodes.push_back(headphone);
+  all_nodes.push_back(external_mic);
+  audio_client_->ChangeAudioNodes(all_nodes);
+  EXPECT_EQ(headphone.id, audio_handler_->GetActiveOutputNode());
+  EXPECT_EQ(external_mic.id, audio_handler_->GetActiveInputNode());
+
+  // Unplug the headphones and mic and check that we switch to the internal
+  // devices.
+  chromeos::AudioNodeList internal_nodes;
+  internal_nodes.push_back(internal_speaker);
+  internal_nodes.push_back(internal_mic);
+  audio_client_->ChangeAudioNodes(internal_nodes);
+  EXPECT_EQ(internal_speaker.id, audio_handler_->GetActiveOutputNode());
+  EXPECT_EQ(internal_mic.id, audio_handler_->GetActiveInputNode());
+
+  // Switch back to the external devices. Mark the previously-activated internal
+  // devices as being active so CrasAudioHandler doesn't complain.
+  SetNodeActive(&all_nodes, internal_speaker.id, true);
+  SetNodeActive(&all_nodes, internal_mic.id, true);
+  audio_client_->ChangeAudioNodes(all_nodes);
+  EXPECT_EQ(headphone.id, audio_handler_->GetActiveOutputNode());
+  EXPECT_EQ(external_mic.id, audio_handler_->GetActiveInputNode());
+}
+
+// Tests that active audio devices are unmuted and set to 100% volume.
+TEST_F(ShellAudioControllerTest, MaxVolume) {
+  chromeos::AudioNodeList nodes;
+  nodes.push_back(CreateNode(chromeos::AUDIO_TYPE_INTERNAL_SPEAKER));
+  nodes.push_back(CreateNode(chromeos::AUDIO_TYPE_INTERNAL_MIC));
+  audio_client_->ChangeAudioNodes(nodes);
+
+  EXPECT_FALSE(audio_handler_->IsOutputMuted());
+  EXPECT_FALSE(audio_handler_->IsInputMuted());
+  EXPECT_EQ(100, audio_handler_->GetOutputVolumePercent());
+  EXPECT_EQ(100, audio_handler_->GetInputGainPercent());
+}
+
+}  // namespace extensions