Use active state on touch start for tray icons

ash/system/overview/overview_button_tray.cc

 // Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "ash/system/overview/overview_button_tray.h"
 
 #include "ash/shelf/shelf_types.h"
 #include "ash/shell.h"
 #include "ash/system/tray/system_tray_delegate.h"
 #include "ash/system/tray/tray_utils.h"
@@ skipping 36 matching lines @@
 OverviewButtonTray::~OverviewButtonTray() {
   Shell::GetInstance()->RemoveShellObserver(this);
 }
 
 void OverviewButtonTray::UpdateAfterLoginStatusChange(
     user::LoginStatus status) {
   UpdateIconVisibility();
 }
 
 bool OverviewButtonTray::PerformAction(const ui::Event& event) {
-  Shell::GetInstance()->window_selector_controller()->ToggleOverview();
+  WindowSelectorController* controller =
+      Shell::GetInstance()->window_selector_controller();
+  controller->ToggleOverview();
+  SetDrawBackgroundAsActive(controller->IsSelecting());

[Mr4D (OOO till 08-26), 2014/09/04 19:58:35]

Shouldn't this command also be dependent on the commandline option?

[jonross, 2014/09/05 16:31:49]

This I added because currently the overview button does not paint an active
state while overview mode is on. Meanwhile the other trays do paint as active,
regardless of the touch feedback experiment.

However I could make this dependent on the command line.

[Mr4D (OOO till 08-26), 2014/09/05 16:38:57]

I think that should be fine.

   return true;
 }
 
 void OverviewButtonTray::OnMaximizeModeStarted() {
   UpdateIconVisibility();
 }
 
 void OverviewButtonTray::OnMaximizeModeEnded() {
   UpdateIconVisibility();
 }
@@ skipping 38 matching lines @@
   }
 }
 
 void OverviewButtonTray::UpdateIconVisibility() {
   SetVisible(Shell::GetInstance()->maximize_mode_controller()->
                  IsMaximizeModeWindowManagerEnabled() &&
              Shell::GetInstance()->window_selector_controller()->CanSelect());
 }
 
 }  // namespace ash