chrome/common/extensions/sync_helper.cc - Issue 515563003: Remove dependency of chrome in WebRequestPermissions.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/common/extensions/sync_helper.cc

Issue 515563003: Remove dependency of chrome in WebRequestPermissions. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Move KWebStoreAppId to extensions. Created 6 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/browser/sync/test/integration/two_client_apps_sync_test.cc ('K') | « chrome/common/extensions/manifest_handlers/app_launch_info.cc ('k') | chrome/renderer/extensions/renderer_permissions_policy_delegate.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/common/extensions/sync_helper.cc

diff --git a/chrome/common/extensions/sync_helper.cc b/chrome/common/extensions/sync_helper.cc

index c38fdbc7ba97bed4bb19d7dc1fac06672d0087c3..b3488a442036b8ced42f1f8955d14937e0ebbd6d 100644

--- a/chrome/common/extensions/sync_helper.cc

+++ b/chrome/common/extensions/sync_helper.cc

@@ -8,6 +8,7 @@

#include "chrome/common/extensions/api/plugins/plugins_handler.h"

#include "chrome/common/extensions/extension_constants.h"

#include "chrome/common/extensions/manifest_url_handler.h"

+#include "extensions/common/constants.h"

#include "extensions/common/extension.h"

#include "extensions/common/manifest.h"

#include "extensions/common/permissions/permissions_data.h"

@@ -88,7 +89,7 @@ bool IsSyncable(const Extension* extension) {

bool is_syncable = (extension->location() == Manifest::INTERNAL &&

!extension->was_installed_by_default());

// Sync the chrome web store to maintain its position on the new tab page.

- is_syncable |= (extension->id() == extension_misc::kWebStoreAppId);

+ is_syncable |= (extension->id() == extensions::kWebStoreAppId);

// Sync the chrome component app to maintain its position on the app list.

is_syncable |= (extension->id() == extension_misc::kChromeAppId);

return is_syncable;