chrome/browser/extensions/pending_extension_manager.cc - Issue 515563003: Remove dependency of chrome in WebRequestPermissions.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/extensions/pending_extension_manager.cc

Issue 515563003: Remove dependency of chrome in WebRequestPermissions. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Move KWebStoreAppId to extensions. Created 6 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/browser/extensions/extension_install_ui_browsertest.cc ('K') | « chrome/browser/extensions/extension_ui_util.cc ('k') | chrome/browser/sync/test/integration/two_client_apps_sync_test.cc » ('j') | chrome/browser/sync/test/integration/two_client_apps_sync_test.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/extensions/pending_extension_manager.cc

diff --git a/chrome/browser/extensions/pending_extension_manager.cc b/chrome/browser/extensions/pending_extension_manager.cc

index ee8e2511ffda696231df1d95e6cd2369658b5274..2a8f0f18e1f9e7254073fefe14c35ad74982117b 100644

--- a/chrome/browser/extensions/pending_extension_manager.cc

+++ b/chrome/browser/extensions/pending_extension_manager.cc

@@ -12,6 +12,7 @@

#include "content/public/browser/browser_thread.h"

#include "extensions/browser/extension_prefs.h"

#include "extensions/browser/extension_registry.h"

+#include "extensions/common/constants.h"

#include "extensions/common/extension.h"

#include "url/gurl.h"

@@ -104,7 +105,7 @@ bool PendingExtensionManager::AddFromSync(

// Make sure we don't ever try to install the CWS app, because even though

// it is listed as a syncable app (because its values need to be synced) it

// should already be installed on every instance.

- if (id == extension_misc::kWebStoreAppId) {

+ if (id == extensions::kWebStoreAppId) {

NOTREACHED();

return false;

}