chrome/browser/extensions/extension_install_ui_browsertest.cc - Issue 515563003: Remove dependency of chrome in WebRequestPermissions.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/extensions/extension_install_ui_browsertest.cc

Issue 515563003: Remove dependency of chrome in WebRequestPermissions. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Updated. Created 6 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/extensions/chrome_content_browser_client_extensions_part.cc ('k') | chrome/browser/extensions/extension_service_unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/extensions/extension_install_ui_browsertest.cc

diff --git a/chrome/browser/extensions/extension_install_ui_browsertest.cc b/chrome/browser/extensions/extension_install_ui_browsertest.cc

index 46629f74c73cb96516ef782bd3eb4d6fbcdc6db1..9834111422e3d8b5a0cbf805dfd191614759a139 100644

--- a/chrome/browser/extensions/extension_install_ui_browsertest.cc

+++ b/chrome/browser/extensions/extension_install_ui_browsertest.cc

@@ -17,7 +17,6 @@

#include "chrome/browser/ui/browser_finder.h"

#include "chrome/browser/ui/tabs/tab_strip_model.h"

#include "chrome/browser/ui/webui/ntp/new_tab_ui.h"

-#include "chrome/common/extensions/extension_constants.h"

#include "chrome/common/url_constants.h"

#include "chrome/test/base/test_switches.h"

#include "chrome/test/base/ui_test_utils.h"

@@ -28,6 +27,7 @@

#include "content/public/test/browser_test_utils.h"

#include "extensions/browser/app_sorting.h"

#include "extensions/browser/extension_prefs.h"

+#include "extensions/common/constants.h"

using content::WebContents;

using extensions::AppSorting;

@@ -227,7 +227,7 @@ IN_PROC_BROWSER_TEST_F(NewTabUISortingBrowserTest,

const std::string app_id = crx_file::id_util::GenerateIdForPath(app_dir);

const extensions::Extension* webstore_extension =

- service->GetInstalledExtension(extension_misc::kWebStoreAppId);

+ service->GetInstalledExtension(extensions::kWebStoreAppId);

EXPECT_TRUE(webstore_extension);

AppSorting* sorting =

extensions::ExtensionPrefs::Get(browser()->profile())->app_sorting();

@@ -242,7 +242,7 @@ IN_PROC_BROWSER_TEST_F(NewTabUISortingBrowserTest,

EXPECT_FALSE(service->GetInstalledExtension(app_id));

// Move the test app from the end to be before the web store.

sorting->OnExtensionMoved(

- app_id, std::string(), extension_misc::kWebStoreAppId);

+ app_id, std::string(), extensions::kWebStoreAppId);

EXPECT_EQ(app_id, last_reordered_extension_id_);

// Now install the app.