Remove dependency of chrome in WebRequestPermissions.

chrome/browser/extensions/api/chrome_extensions_api_client.cc

 // Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/extensions/api/chrome_extensions_api_client.h"
 
 #include "base/files/file_path.h"
 #include "chrome/browser/extensions/api/storage/sync_value_store_cache.h"
 #include "chrome/browser/guest_view/app_view/chrome_app_view_guest_delegate.h"
 #include "chrome/browser/guest_view/extension_options/extension_options_guest.h"
 #include "chrome/browser/guest_view/web_view/chrome_web_view_guest_delegate.h"
 #include "chrome/browser/guest_view/web_view/chrome_web_view_permission_helper_delegate.h"
+#include "chrome/common/extensions/extension_constants.h"
 #include "content/public/browser/browser_context.h"
 #include "content/public/browser/browser_thread.h"
 #include "device/hid/hid_service.h"
 #include "extensions/browser/guest_view/app_view/app_view_guest.h"
 #include "extensions/browser/guest_view/web_view/web_view_guest.h"
 #include "extensions/browser/guest_view/web_view/web_view_permission_helper.h"
 
 #if defined(ENABLE_CONFIGURATION_POLICY)
 #include "chrome/browser/extensions/api/storage/managed_value_store_cache.h"
 #endif
@@ skipping 63 matching lines @@
         content::BrowserThread::GetMessageLoopProxyForThread(
             content::BrowserThread::UI)));
   }
   return hid_service_.get();
 }
 
 void ChromeExtensionsAPIClient::RegisterGuestViewTypes() {
   ExtensionOptionsGuest::Register();
 }
 
+bool ChromeExtensionsAPIClient::MustNotBeModifiedURL(const GURL& url) {

[Ken Rockot(use gerrit already), 2014/08/29 07:00:22]

Please wait on this. I need to dig up a patch I have in a local branch which
also refactored these extension_urls. The end result is that you won't need this
method at all on the API client, because the extension_urls functions are going
to move to //extensions.

So I would say, for this CL, just leave this code in its original place with the
dependency remaining on chrome. I will clean it up ASAP with the patch I already
have in progress.

[Xi Han, 2014/08/29 14:39:24]

Cool, I will revert these changes and wait for your cl landed:)

+   GURL::Replacements replacements;
+  replacements.ClearQuery();
+  replacements.ClearRef();
+  GURL url_without_query = url.ReplaceComponents(replacements);
+  return extension_urls::IsWebstoreUpdateUrl(url_without_query) ||
+      extension_urls::IsBlacklistUpdateUrl(url);
+}
+
+const std::string ChromeExtensionsAPIClient::WebStoreAppId() {
+  return extension_misc::kWebStoreAppId;

[Ken Rockot(use gerrit already), 2014/08/29 07:00:22]

I think it's OK to just move this constant to //extensions/common/constants.h/cc
for now. No need to add the client interface!

[Xi Han, 2014/08/29 14:39:24]

Done.

+}
+
 }  // namespace extensions