Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(457)

Side by Side Diff: chrome/common/extensions/sync_helper.cc

Issue 515563003: Remove dependency of chrome in WebRequestPermissions. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Updated. Created 6 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2013 The Chromium Authors. All rights reserved. 1 // Copyright 2013 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "chrome/common/extensions/sync_helper.h" 5 #include "chrome/common/extensions/sync_helper.h"
6 6
7 #include "base/logging.h" 7 #include "base/logging.h"
8 #include "chrome/common/extensions/api/plugins/plugins_handler.h" 8 #include "chrome/common/extensions/api/plugins/plugins_handler.h"
9 #include "chrome/common/extensions/extension_constants.h" 9 #include "chrome/common/extensions/extension_constants.h"
10 #include "chrome/common/extensions/manifest_url_handler.h" 10 #include "chrome/common/extensions/manifest_url_handler.h"
11 #include "extensions/common/constants.h"
11 #include "extensions/common/extension.h" 12 #include "extensions/common/extension.h"
12 #include "extensions/common/manifest.h" 13 #include "extensions/common/manifest.h"
13 #include "extensions/common/permissions/permissions_data.h" 14 #include "extensions/common/permissions/permissions_data.h"
14 15
15 namespace extensions { 16 namespace extensions {
16 namespace sync_helper { 17 namespace sync_helper {
17 18
18 namespace { 19 namespace {
19 20
20 enum SyncType { 21 enum SyncType {
(...skipping 60 matching lines...) Expand 10 before | Expand all | Expand 10 after
81 bool IsSyncable(const Extension* extension) { 82 bool IsSyncable(const Extension* extension) {
82 // TODO(akalin): Figure out if we need to allow some other types. 83 // TODO(akalin): Figure out if we need to allow some other types.
83 84
84 // Default apps are not synced because otherwise they will pollute profiles 85 // Default apps are not synced because otherwise they will pollute profiles
85 // that don't already have them. Specially, if a user doesn't have default 86 // that don't already have them. Specially, if a user doesn't have default
86 // apps, creates a new profile (which get default apps) and then enables sync 87 // apps, creates a new profile (which get default apps) and then enables sync
87 // for it, then their profile everywhere gets the default apps. 88 // for it, then their profile everywhere gets the default apps.
88 bool is_syncable = (extension->location() == Manifest::INTERNAL && 89 bool is_syncable = (extension->location() == Manifest::INTERNAL &&
89 !extension->was_installed_by_default()); 90 !extension->was_installed_by_default());
90 // Sync the chrome web store to maintain its position on the new tab page. 91 // Sync the chrome web store to maintain its position on the new tab page.
91 is_syncable |= (extension->id() == extension_misc::kWebStoreAppId); 92 is_syncable |= (extension->id() == extensions::kWebStoreAppId);
92 // Sync the chrome component app to maintain its position on the app list. 93 // Sync the chrome component app to maintain its position on the app list.
93 is_syncable |= (extension->id() == extension_misc::kChromeAppId); 94 is_syncable |= (extension->id() == extension_misc::kChromeAppId);
94 return is_syncable; 95 return is_syncable;
95 } 96 }
96 97
97 bool IsSyncableExtension(const Extension* extension) { 98 bool IsSyncableExtension(const Extension* extension) {
98 return GetSyncType(extension) == SYNC_TYPE_EXTENSION; 99 return GetSyncType(extension) == SYNC_TYPE_EXTENSION;
99 } 100 }
100 101
101 bool IsSyncableApp(const Extension* extension) { 102 bool IsSyncableApp(const Extension* extension) {
102 return GetSyncType(extension) == SYNC_TYPE_APP; 103 return GetSyncType(extension) == SYNC_TYPE_APP;
103 } 104 }
104 105
105 } // namespace sync_helper 106 } // namespace sync_helper
106 } // namespace extensions 107 } // namespace extensions
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698