content/test/gpu/gpu_tests/webgl_conformance.py - Issue 515513003: Changed how we log uncaught exceptions by the WebGL tests

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/test/gpu/gpu_tests/webgl_conformance.py

Issue 515513003: Changed how we log uncaught exceptions by the WebGL tests (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: removed resart browser after each page Created 6 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: content/test/gpu/gpu_tests/webgl_conformance.py

diff --git a/content/test/gpu/gpu_tests/webgl_conformance.py b/content/test/gpu/gpu_tests/webgl_conformance.py

index df297ee87797718e184e831ce736320994f0cecd..dca3cce3e8c2c0038d9fbb6eb536896783b03cb6 100644

--- a/content/test/gpu/gpu_tests/webgl_conformance.py

+++ b/content/test/gpu/gpu_tests/webgl_conformance.py

@@ -53,10 +53,7 @@ conformance_harness_script = r"""

window.parent.webglTestHarness = testHarness;

window.console.log = testHarness.log;

window.onerror = function(message, url, line) {

- testHarness._failures++;

- if (message) {

- testHarness.log(message);

- }

+ testHarness.reportResults(null, false, message);

Ken Russell (switch to Gerrit) 2014/08/27 21:57:23 Should this pass the URL to reportResults instead

testHarness.notifyFinished(null);

};

"""

« no previous file with comments | « no previous file | no next file » | no next file with comments »