src/pdf/SkPDFDevice.cpp - Issue 515493003: JPEG(JFIF only) directly embedded into PDF

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/pdf/SkPDFDevice.cpp

Issue 515493003: JPEG(JFIF only) directly embedded into PDF (Closed) Base URL: https://skia.googlesource.com/skia.git@master

Patch Set: nits from reed@ Created 6 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: src/pdf/SkPDFDevice.cpp

diff --git a/src/pdf/SkPDFDevice.cpp b/src/pdf/SkPDFDevice.cpp

index 5946b9ae6f293fcadc43d73ba2758eee8cc4bb92..ec07a8ff0ed42b8872fb78bdbd3296632180b84a 100644

--- a/src/pdf/SkPDFDevice.cpp

+++ b/src/pdf/SkPDFDevice.cpp

@@ -2182,8 +2182,8 @@ void SkPDFDevice::internalDrawBitmap(const SkMatrix& origMatrix,

return;

}

- SkAutoTUnref<SkPDFImage> image(

- SkPDFImage::CreateImage(*bitmap, subset, fEncoder));

+ SkAutoTUnref<SkPDFObject> image(

+ SkPDFCreateImageObject(*bitmap, subset, fEncoder));

if (!image) {

return;

}

« no previous file with comments | « gyp/tests.gypi ('k') | src/pdf/SkPDFImage.h » ('j') | no next file with comments »