Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(745)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 515493002: ServiceWorker: Clean up WebServiceWorkerRegistrationImpl (Closed)

Created:
6 years, 3 months ago by nhiroki
Modified:
6 years, 3 months ago
Reviewers:
shimazu, horo
CC:
chromium-reviews, michaeln, jsbell+serviceworker_chromium.org, tzik, serviceworker-reviews, jam, kinuko+serviceworker, darin-cc_chromium.org, horo+watch_chromium.org
Base URL:
http://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

ServiceWorker: Clean up WebServiceWorkerRegistrationImpl BUG=n/a TEST=should pass all existing tests (no behavioral change) Committed: https://crrev.com/ebcee6accfb300dca1558ccb11cfde33c9bf0a57 Cr-Commit-Position: refs/heads/master@{#292302}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+26 lines, -25 lines) Patch
M content/child/service_worker/service_worker_dispatcher.cc View 3 chunks +3 lines, -3 lines 0 comments Download
M content/child/service_worker/web_service_worker_registration_impl.h View 1 chunk +5 lines, -4 lines 0 comments Download
M content/child/service_worker/web_service_worker_registration_impl.cc View 1 chunk +18 lines, -18 lines 0 comments Download

Messages

Total messages: 9 (0 generated)
nhiroki
nhiroki@chromium.org changed reviewers: + horo@chromium.org, shimazu@chromium.org
6 years, 3 months ago (2014-08-27 11:37:10 UTC) #1
nhiroki
Hi, can you review this? Thanks!
6 years, 3 months ago (2014-08-27 11:37:39 UTC) #2
horo
lgtm
6 years, 3 months ago (2014-08-27 15:27:20 UTC) #3
shimazu
lgtm
6 years, 3 months ago (2014-08-28 01:48:49 UTC) #4
nhiroki
On 2014/08/28 01:48:49, makoto wrote: > lgtm Thank you!
6 years, 3 months ago (2014-08-28 01:49:11 UTC) #5
nhiroki
The CQ bit was checked by nhiroki@chromium.org
6 years, 3 months ago (2014-08-28 01:49:15 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/nhiroki@chromium.org/515493002/1
6 years, 3 months ago (2014-08-28 01:50:15 UTC) #7
commit-bot: I haz the power
Committed patchset #1 (id:1) as 009028f5b7363c3d45f892dfca9b7528eeb3fc33
6 years, 3 months ago (2014-08-28 03:00:43 UTC) #8
commit-bot: I haz the power
6 years, 3 months ago (2014-09-10 02:56:50 UTC) #9
Message was sent while issue was closed. 
Patchset 1 (id:??) landed as
https://crrev.com/ebcee6accfb300dca1558ccb11cfde33c9bf0a57
Cr-Commit-Position: refs/heads/master@{#292302}

Powered by Google App Engine
This is Rietveld 408576698