Deflakify CastStreamingApiTest.EndToEnd, enabling it for Release builds.

Deflakify CastStreamingApiTest.EndToEnd, enabling it for Release builds.

An analysis was performed for sources of flakiness in this test.  A
number of implementation problems have been resolved in recent changes,
with this change focusing on addressing problems with the test code
itself:

1. Do not require the color to match the tone at the same time.  A/V
   sync belongs in a perf test.
2. Do not require a color or tone to be held for a full half-second.
   Instead, any momentary observation that matches expectations is
   sufficient.
3. Only examine the content part of each video frame (i.e., exclude the
   surrounding black borders caused by letterboxing).
4. Generate the source content using a canvas and
   requestAnimationFrame().  The source content has a little "ball"
   animating within it to ensure changing video frames are being sent
   through end-to-end.

Also added AES keys to test end-to-end with encryption enabled.

This change re-enables the test for Release builds only.  Once the test
has proven to be stable again, it will be re-enabled for Debug builds as
well.  Baby steps...

BUG=396413
Committed: https://crrev.com/4b0ebd322e95bd691a510c19b16fb258be86ef51
Cr-Commit-Position: refs/heads/master@{#292539}

[miu, 2014-08-28 03:40:16]

miu@chromium.org changed reviewers:
+ hubbe@chromium.org

[miu, 2014-08-28 03:40:16]

hubbe: PTAL.

[hubbe, 2014-08-28 17:29:23]

lgtm

https://codereview.chromium.org/515473004/diff/20001/chrome/browser/extension...
File chrome/browser/extensions/api/cast_streaming/cast_streaming_apitest.cc
(right):

https://codereview.chromium.org/515473004/diff/20001/chrome/browser/extension...
chrome/browser/extensions/api/cast_streaming/cast_streaming_apitest.cc:211:
const gfx::Rect region = FindLetterboxedContentRegion(video_frame);
Excluding the letterboxing *and* calculating the median seems redundant.
Just using the median is enough, isn't it?
(Unless the letterboxing is bigger than the region in the middle, which would be
bad...)

[Alpha Left Google, 2014-08-28 18:13:23]

hclam@chromium.org changed reviewers:
+ hclam@chromium.org

[Alpha Left Google, 2014-08-28 18:13:23]

LGTM.

[miu, 2014-08-28 18:58:17]

https://codereview.chromium.org/515473004/diff/20001/chrome/browser/extension...
File chrome/browser/extensions/api/cast_streaming/cast_streaming_apitest.cc
(right):

https://codereview.chromium.org/515473004/diff/20001/chrome/browser/extension...
chrome/browser/extensions/api/cast_streaming/cast_streaming_apitest.cc:211:
const gfx::Rect region = FindLetterboxedContentRegion(video_frame);
On 2014/08/28 17:29:23, hubbe wrote:
> Excluding the letterboxing *and* calculating the median seems redundant.
> Just using the median is enough, isn't it?
> (Unless the letterboxing is bigger than the region in the middle, which would
be
> bad...)

tl;dr: I left this in to avoid flakiness caused by platforms that do not respect
the browser window's desired size.

On my dev desktop, I use a tiling window manager which totally disrespects the
browser's desire to be a certain size.  Because the browser_test window had a
very non-square aspect ratio, video frames would end up looking like this:

####...####
####...####
####...####
####...####
####...####
####...####

...where the median color would be black because of the borders on the sides.

[miu, 2014-08-28 23:04:21]

The CQ bit was checked by miu@chromium.org

[commit-bot: I haz the power, 2014-08-28 23:05:42]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/miu@chromium.org/515473004/60001

[commit-bot: I haz the power, 2014-08-29 00:06:20]

FYI, CQ is re-trying this CL (attempt #1).
The failing builders are:
  win_chromium_x64_rel_swarming on tryserver.chromium.win
(http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_x64_...)

[commit-bot: I haz the power, 2014-08-29 01:31:18]

Committed patchset #4 (id:60001) as 888a30dd0c2715de1e861542438b27ebdad08ccb

[commit-bot: I haz the power, 2014-09-10 03:04:57]

Patchset 4 (id:??) landed as
https://crrev.com/4b0ebd322e95bd691a510c19b16fb258be86ef51
Cr-Commit-Position: refs/heads/master@{#292539}