Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(222)

Issue 515443002: Audio Player: Don't update the track list when the list is not changed (Closed)

Created:
6 years, 3 months ago by yoshiki
Modified:
6 years, 3 months ago
Reviewers:
fukino
CC:
chromium-reviews, rginda+watch_chromium.org, mtomasz+watch_chromium.org, yoshiki+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Audio Player: Don't update the track list when the list is not changed Previously, when user clicked the audio file on Files.app, the track list was updated unexpectedly and the current track index was set to the default (the first file) for a very short time just before the index was updated to the selected file. This unexpected change in short period made the playback time reset and caused the issue (crbug.com/395868). This patch fixes this issue. BUG=395868 TEST=none Committed: https://crrev.com/9a2e0a8a8d6a7c972fb18c0be66c85e498e77425 Cr-Commit-Position: refs/heads/master@{#292565}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+12 lines, -5 lines) Patch
M ui/file_manager/file_manager/audio_player/js/audio_player.js View 1 chunk +12 lines, -5 lines 0 comments Download

Messages

Total messages: 7 (0 generated)
yoshiki
yoshiki@chromium.org changed reviewers: + fukino@chromium.org
6 years, 3 months ago (2014-08-27 08:58:09 UTC) #1
yoshiki
@fukino-san, could you take a look? Thanks
6 years, 3 months ago (2014-08-27 08:58:24 UTC) #2
fukino
On 2014/08/27 08:58:24, yoshiki wrote: > @fukino-san, could you take a look? Thanks lgtm, but ...
6 years, 3 months ago (2014-08-27 11:09:49 UTC) #3
yoshiki
The CQ bit was checked by yoshiki@chromium.org
6 years, 3 months ago (2014-08-29 02:36:04 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/yoshiki@chromium.org/515443002/1
6 years, 3 months ago (2014-08-29 02:38:01 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1) as 160602786710dc352104ac56ed5c90c37322f64e
6 years, 3 months ago (2014-08-29 03:34:46 UTC) #6
commit-bot: I haz the power
6 years, 3 months ago (2014-09-10 03:06:01 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/9a2e0a8a8d6a7c972fb18c0be66c85e498e77425
Cr-Commit-Position: refs/heads/master@{#292565}

Powered by Google App Engine
This is Rietveld 408576698