Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(23)

Issue 515433002: Cleanup: Remove unneeded ui/ grit header includes. (Closed)

Created:
6 years, 3 months ago by Lei Zhang
Modified:
6 years, 3 months ago
Reviewers:
tfarina, James Cook
CC:
chromium-reviews, extensions-reviews_chromium.org, sadrul, estade+watch_chromium.org, benquan, tfarina, Dane Wallinga, dyu1, chromium-apps-reviews_chromium.org, rouslan+autofillwatch_chromium.org, kalyank, markusheintz_, James Su, Ilya Sherman, ben+ash_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Cleanup: Remove unneeded ui/ grit header includes. Command used: for f in `find ui -name *.grd`; do echo GRD: $f; ./tools/unused-grit-header.py $f android_webview apps ash cc chromecast chromeos content chrome extensions gpu media pdf printing remoting webkit; done Committed: https://crrev.com/86693c47d7991f228803c507ce2879781a6d67b1 Cr-Commit-Position: refs/heads/master@{#292226}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -19 lines) Patch
M ash/system/user/accounts_detailed_view.cc View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/chrome_browser_main.cc View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/custom_home_pages_table_model.cc View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/extensions/extension_action.cc View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/ssl/ssl_blocking_page.cc View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/themes/theme_service.cc View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/ui/cocoa/browser/edit_search_engine_cocoa_controller.mm View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/ui/cocoa/browser/edit_search_engine_cocoa_controller_unittest.mm View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/ui/cocoa/hung_renderer_controller.mm View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/ui/cocoa/notifications/message_center_tray_bridge.mm View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/ui/cocoa/restart_browser.mm View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/ui/cocoa/website_settings/website_settings_bubble_controller.mm View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/ui/views/autofill/autofill_dialog_views.cc View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/ui/views/edit_search_engine_dialog.cc View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/ui/views/frame/browser_view.cc View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/ui/views/omnibox/omnibox_view_views.cc View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/ui/views/session_crashed_bubble_view.cc View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/ui/views/website_settings/permissions_bubble_view.cc View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/ui/website_settings/website_settings_ui.cc View 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 11 (0 generated)
Lei Zhang
thestig@chromium.org changed reviewers: + jamescook@chromium.org
6 years, 3 months ago (2014-08-27 18:58:37 UTC) #1
Lei Zhang
stamp please
6 years, 3 months ago (2014-08-27 18:58:37 UTC) #2
tfarina
tfarina@chromium.org changed reviewers: + tfarina@chromium.org
6 years, 3 months ago (2014-08-27 19:09:35 UTC) #3
tfarina
lgtm could you include the command line you used for this in the CL description?
6 years, 3 months ago (2014-08-27 19:09:35 UTC) #4
Lei Zhang
On 2014/08/27 19:09:35, tfarina wrote: > lgtm > > could you include the command line ...
6 years, 3 months ago (2014-08-27 19:12:48 UTC) #5
James Cook
lgtm
6 years, 3 months ago (2014-08-27 19:46:57 UTC) #6
Lei Zhang
The CQ bit was checked by thestig@chromium.org
6 years, 3 months ago (2014-08-27 20:18:09 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/thestig@chromium.org/515433002/1
6 years, 3 months ago (2014-08-27 20:19:06 UTC) #8
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: android_arm64_dbg_recipe on tryserver.chromium.linux ...
6 years, 3 months ago (2014-08-27 21:03:04 UTC) #9
commit-bot: I haz the power
Committed patchset #1 (id:1) as 6cb7bf38079255f2c5cca178bc01d3c1af34fde9
6 years, 3 months ago (2014-08-27 21:24:42 UTC) #10
commit-bot: I haz the power
6 years, 3 months ago (2014-09-10 02:54:08 UTC) #11
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/86693c47d7991f228803c507ce2879781a6d67b1
Cr-Commit-Position: refs/heads/master@{#292226}

Powered by Google App Engine
This is Rietveld 408576698