Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(649)

Unified Diff: content/browser/compositor/delegated_frame_host.cc

Issue 515373003: Don't add surface callback to ack frame if compositor doesn't exist (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 6 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: content/browser/compositor/delegated_frame_host.cc
diff --git a/content/browser/compositor/delegated_frame_host.cc b/content/browser/compositor/delegated_frame_host.cc
index 488b138b772e158b706c4e870f7a43c45bc738ae..95349cb9a2b22ce9d1c824203d677ced8ab28899 100644
--- a/content/browser/compositor/delegated_frame_host.cc
+++ b/content/browser/compositor/delegated_frame_host.cc
@@ -360,6 +360,7 @@ void DelegatedFrameHost::SwapDelegatedFrame(
last_output_surface_id_ = output_surface_id;
}
bool modified_layers = false;
+ ui::Compositor* compositor = client_->GetCompositor();
if (frame_size.IsEmpty()) {
DCHECK(frame_data->resource_list.empty());
EvictDelegatedFrame();
@@ -388,12 +389,14 @@ void DelegatedFrameHost::SwapDelegatedFrame(
scoped_ptr<cc::CompositorFrame> compositor_frame =
make_scoped_ptr(new cc::CompositorFrame());
compositor_frame->delegated_frame_data = frame_data.Pass();
+ base::Closure ack_callback;
+ if (compositor) {
+ ack_callback = base::Bind(&DelegatedFrameHost::SendDelegatedFrameAck,
+ AsWeakPtr(),
+ output_surface_id);
+ }
surface_factory_->SubmitFrame(
- surface_id_,
- compositor_frame.Pass(),
- base::Bind(&DelegatedFrameHost::SendDelegatedFrameAck,
- AsWeakPtr(),
- output_surface_id));
+ surface_id_, compositor_frame.Pass(), ack_callback);
} else {
if (!resource_collection_.get()) {
resource_collection_ = new cc::DelegatedFrameResourceCollection;
@@ -429,7 +432,6 @@ void DelegatedFrameHost::SwapDelegatedFrame(
pending_delegated_ack_count_++;
- ui::Compositor* compositor = client_->GetCompositor();
if (!compositor) {
SendDelegatedFrameAck(output_surface_id);
} else if (!use_surfaces_) {
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698