Issue 515373003: Don't add surface callback to ack frame if compositor doesn't exist

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 515373003: Don't add surface callback to ack frame if compositor doesn't exist (Closed)

Created:
6 years, 3 months ago by jbauman

Modified:
6 years, 3 months ago

Reviewers:
jamesr

CC:
chromium-reviews, jam, sievers+watch_chromium.org, jbauman+watch_chromium.org, darin-cc_chromium.org, kalyank, piman+watch_chromium.org, danakj+watch_chromium.org, miu+watch_chromium.org

Base URL:
https://chromium.googlesource.com/chromium/src.git@master

Project:
chromium

Visibility:
Public.

More Reviews

Description

Don't add surface callback to ack frame if compositor doesn't exist In this case the code below will ack the frame immediately anyway. TEST=BrowserTest.ShouldShowLocationBar Committed: https://crrev.com/159c27b073e61cf021c4431dd095db7b4b661d3b Cr-Commit-Position: refs/heads/master@{#292506}

Patch Set 1 #

Created: 6 years, 3 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+8 lines, -6 lines)			Patch
	M	content/browser/compositor/delegated_frame_host.cc	View		3 chunks	+8 lines, -6 lines	0 comments	Download

Messages

Total messages: 7 (0 generated)

Expand Messages | Collapse Messages

jbauman

jbauman@chromium.org changed reviewers: + jamesr@chromium.org

6 years, 3 months ago (2014-08-28 21:52:19 UTC) #1

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/jbauman@chromium.org/515373003/1

6 years, 3 months ago (2014-08-28 22:03:14 UTC) #5

commit-bot: I haz the power

Committed patchset #1 (id:1) as da3892c2480525d936f49b821137001925c52ed7

6 years, 3 months ago (2014-08-28 23:51:22 UTC) #6

commit-bot: I haz the power

6 years, 3 months ago (2014-09-10 03:03:50 UTC) #7

Message was sent while issue was closed.

Patchset 1 (id:??) landed as
https://crrev.com/159c27b073e61cf021c4431dd095db7b4b661d3b
Cr-Commit-Position: refs/heads/master@{#292506}

Expand Messages | Collapse Messages