Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(41)

Issue 515303003: Landing Recent QUIC Changes. (Closed)

Created:
6 years, 3 months ago by ramant (doing other things)
Modified:
6 years, 3 months ago
CC:
chromium-reviews, cbentzel+watch_chromium.org, wtc, Jana, Ian Swett, rjshade, alyssar
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Landing Recent QUIC Changes. Ensure the QuicConnection's writer is not write blocked before trying to write another packet. Fix for Chrome crash bug 409191. Merge internal change: 74635422 BUG=409191 Nest a QUIC SerializedPacket inside a QUIC QueuedPacket. Merge internal change: 74239145 https://codereview.chromium.org/509203003/ Remove PacketType from QUIC because the QUEUED type is not used and the other types can be reduced to a bool. Merge internal change: 74148481 https://codereview.chromium.org/515003003/ Don't send a QUIC SCUP message until after handshake confirmed. A server config update was occasionally being sent before the crypto handshake was complete, causing the client to close the connection. Merge internal change: 74132773 https://codereview.chromium.org/516713002/ Change TransmissionInfo's all_transmissions SequenceNumberSet* to default to NULL, and only be present if there are multiple transmissions. Estimated to save ~2% of CPU. Merge internal change: 74076012 https://codereview.chromium.org/509073004/ Log the quic version for internal server tracing. Not used in production. Merge internal change: 74069715 https://codereview.chromium.org/514043002/ Optimize QuicUnackedPacketMap by changing from a LinkedHashMap to a deque. Estimated to save ~3% of CPU based on pprof profiling of 100 large gets on tools/quic/end_to_end_test.cc. Merge internal change: 74054196 https://codereview.chromium.org/514033002/ Unit test for empty packet closes QUIC connection bug. Merge internal change: 74041239 https://codereview.chromium.org/495423011/ Log the QUIC transmission type in QUIC internal server trace visitor. Not used in production. Merge internal change: 73895739 https://codereview.chromium.org/514023002/ Not used in production. Log whether a QUIC packet sent was a crypto packet or not for internal server side tracing. Merge internal change: 73894063 https://codereview.chromium.org/515003002/ Fix a QUIC bug in which PING frames were not being ACK'd. Merge internal change: 73837644 https://codereview.chromium.org/512933005/ R=rch@chromium.org Committed: https://chromium.googlesource.com/chromium/src/+/27f3f1894f09a96112df50fddd32895b4677f949 Committed: https://crrev.com/dd4bf8f4a41ec6609e2b6bee2e0aa5d076bced8f Cr-Commit-Position: refs/heads/master@{#293030}

Patch Set 1 #

Patch Set 2 : rebase with TOT #

Patch Set 3 : Bug fix for 409191 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+456 lines, -523 lines) Patch
M net/quic/congestion_control/tcp_loss_algorithm.cc View 1 chunk +11 lines, -10 lines 0 comments Download
M net/quic/congestion_control/time_loss_algorithm.cc View 1 chunk +7 lines, -5 lines 0 comments Download
M net/quic/quic_connection.h View 1 2 5 chunks +15 lines, -19 lines 0 comments Download
M net/quic/quic_connection.cc View 1 2 20 chunks +93 lines, -80 lines 0 comments Download
M net/quic/quic_connection_logger.h View 1 chunk +2 lines, -1 line 0 comments Download
M net/quic/quic_connection_test.cc View 1 2 6 chunks +55 lines, -142 lines 0 comments Download
M net/quic/quic_crypto_server_stream.cc View 1 chunk +2 lines, -1 line 0 comments Download
M net/quic/quic_crypto_server_stream_test.cc View 1 chunk +6 lines, -0 lines 0 comments Download
M net/quic/quic_protocol.h View 3 chunks +3 lines, -4 lines 0 comments Download
M net/quic/quic_protocol.cc View 3 chunks +4 lines, -10 lines 0 comments Download
M net/quic/quic_sent_entropy_manager.cc View 1 chunk +1 line, -1 line 0 comments Download
M net/quic/quic_sent_packet_manager.h View 5 chunks +9 lines, -8 lines 0 comments Download
M net/quic/quic_sent_packet_manager.cc View 15 chunks +64 lines, -84 lines 0 comments Download
M net/quic/quic_sent_packet_manager_test.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M net/quic/quic_unacked_packet_map.h View 6 chunks +13 lines, -6 lines 0 comments Download
M net/quic/quic_unacked_packet_map.cc View 9 chunks +123 lines, -140 lines 0 comments Download
M net/quic/quic_unacked_packet_map_test.cc View 4 chunks +6 lines, -8 lines 0 comments Download
M net/quic/test_tools/quic_sent_packet_manager_peer.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M net/tools/quic/quic_client_session_test.cc View 3 chunks +38 lines, -0 lines 0 comments Download

Messages

Total messages: 20 (4 generated)
ramant (doing other things)
6 years, 3 months ago (2014-08-28 17:53:55 UTC) #1
ramant (doing other things)
On 2014/08/28 17:53:55, ramant wrote: Hi Ryan, This CL is a merge of all the ...
6 years, 3 months ago (2014-08-28 22:15:59 UTC) #2
Ryan Hamilton
lgtm
6 years, 3 months ago (2014-08-28 22:22:12 UTC) #3
ramant (doing other things)
The CQ bit was checked by rtenneti@chromium.org
6 years, 3 months ago (2014-08-28 22:25:56 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/rtenneti@chromium.org/515303003/1
6 years, 3 months ago (2014-08-28 22:27:25 UTC) #5
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: win8_chromium_rel on tryserver.chromium.win ...
6 years, 3 months ago (2014-08-28 23:39:57 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1) as 27f3f1894f09a96112df50fddd32895b4677f949
6 years, 3 months ago (2014-08-29 00:54:36 UTC) #7
ramant (doing other things)
A revert of this CL (patchset #1 id:1) has been created in https://codereview.chromium.org/523813003/ by rtenneti@chromium.org. ...
6 years, 3 months ago (2014-08-29 23:36:26 UTC) #8
ramant (doing other things)
Hi Ryan and Ian, Merged the changes from internal CL: 74635422. Will merge changes before ...
6 years, 3 months ago (2014-09-02 22:29:18 UTC) #10
Ryan Hamilton
lgtm
6 years, 3 months ago (2014-09-02 22:32:08 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/rtenneti@chromium.org/515303003/40001
6 years, 3 months ago (2014-09-02 22:37:51 UTC) #13
commit-bot: I haz the power
Failed to commit the patch.
6 years, 3 months ago (2014-09-02 23:54:16 UTC) #15
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/rtenneti@chromium.org/515303003/40001
6 years, 3 months ago (2014-09-03 00:06:23 UTC) #17
commit-bot: I haz the power
Committed patchset #3 (id:40001) as 93ae0005c8e7d8386d37f010ecc4b2001541ea07
6 years, 3 months ago (2014-09-03 00:46:18 UTC) #18
commit-bot: I haz the power
Patchset 3 (id:??) landed as https://crrev.com/33089992bfb2436986b9be2ddd76ace321430de8 Cr-Commit-Position: refs/heads/master@{#292527}
6 years, 3 months ago (2014-09-10 03:04:32 UTC) #19
commit-bot: I haz the power
6 years, 3 months ago (2014-09-10 03:22:13 UTC) #20
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/dd4bf8f4a41ec6609e2b6bee2e0aa5d076bced8f
Cr-Commit-Position: refs/heads/master@{#293030}

Powered by Google App Engine
This is Rietveld 408576698