Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(181)

Issue 515303002: Fixups in TemplateURLService for scoped_refptr operator T* removal (Closed)

Created:
6 years, 3 months ago by dcheng
Modified:
6 years, 3 months ago
Reviewers:
Peter Kasting
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Fixups in TemplateURLService for scoped_refptr operator T* removal BUG=110610 Committed: https://crrev.com/4082bfc58da57d17f82ce409865b2b77df0f0556 Cr-Commit-Position: refs/heads/master@{#292442}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+9 lines, -8 lines) Patch
M components/search_engines/template_url_service.h View 1 chunk +8 lines, -7 lines 0 comments Download
M components/search_engines/template_url_service.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 7 (0 generated)
dcheng
dcheng@chromium.org changed reviewers: + pkasting@chromium.org
6 years, 3 months ago (2014-08-28 17:46:10 UTC) #1
dcheng
Manual fixups for cases that the automated tool for this conversion opted to skip. In ...
6 years, 3 months ago (2014-08-28 17:46:10 UTC) #2
Peter Kasting
LGTM
6 years, 3 months ago (2014-08-28 18:30:29 UTC) #3
dcheng
The CQ bit was checked by dcheng@chromium.org
6 years, 3 months ago (2014-08-28 18:33:54 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/dcheng@chromium.org/515303002/1
6 years, 3 months ago (2014-08-28 18:35:32 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1) as 1d215ce9a69fb27ab1f691f04d3dc0987be53705
6 years, 3 months ago (2014-08-28 19:22:19 UTC) #6
commit-bot: I haz the power
6 years, 3 months ago (2014-09-10 03:01:32 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/4082bfc58da57d17f82ce409865b2b77df0f0556
Cr-Commit-Position: refs/heads/master@{#292442}

Powered by Google App Engine
This is Rietveld 408576698