Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(60)

Issue 515243002: Expose platform thread id on blink::WebThread (Closed)

Created:
6 years, 3 months ago by yurys
Modified:
6 years, 3 months ago
CC:
chromium-reviews, qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, jam, yzshen+watch_chromium.org, abarth-chromium, Aaron Boodman, darin-cc_chromium.org, darin (slow to review), ben+mojo_chromium.org, alph, caseq
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Expose platform thread id on blink::WebThread DevTools code needs access to platform thread id in order to collect Worker thread ids and based on them differentiate worker threads in recorded trace events. Blink part of the change: https://codereview.chromium.org/514193002/ BUG=401895 Committed: https://crrev.com/07e7a118841a8f06d6634d20b978b5a3bcf183ac Cr-Commit-Position: refs/heads/master@{#294345}

Patch Set 1 #

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+28 lines, -1 line) Patch
M content/child/webthread_impl.h View 3 chunks +5 lines, -0 lines 0 comments Download
M content/child/webthread_impl.cc View 2 chunks +10 lines, -1 line 0 comments Download
M mojo/services/html_viewer/webthread_impl.h View 3 chunks +5 lines, -0 lines 0 comments Download
M mojo/services/html_viewer/webthread_impl.cc View 2 chunks +8 lines, -0 lines 0 comments Download

Messages

Total messages: 11 (2 generated)
yurys
yurys@chromium.org changed reviewers: + darin@chromium.org
6 years, 3 months ago (2014-08-28 15:30:14 UTC) #1
yurys
@darin: can you take a look please?
6 years, 3 months ago (2014-09-09 09:07:59 UTC) #2
yurys
On 2014/09/09 09:07:59, yurys wrote: > @darin: can you take a look please? @darin: it ...
6 years, 3 months ago (2014-09-10 06:13:21 UTC) #3
yurys
@jamesr: please review mojo/ changes @jochen: please review content/ changes
6 years, 3 months ago (2014-09-11 05:40:02 UTC) #5
darin (slow to review)
LGTM, sorry about that!
6 years, 3 months ago (2014-09-11 06:08:14 UTC) #6
yurys
On 2014/09/11 06:08:14, darin wrote: > LGTM, sorry about that! np, thank you!
6 years, 3 months ago (2014-09-11 06:14:32 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patchset/515243002/20001
6 years, 3 months ago (2014-09-11 06:24:28 UTC) #9
commit-bot: I haz the power
Committed patchset #2 (id:20001) as da6986dafdf87a98d0eb024dde681be7746f3724
6 years, 3 months ago (2014-09-11 07:29:01 UTC) #10
commit-bot: I haz the power
6 years, 3 months ago (2014-09-11 07:38:27 UTC) #11
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/07e7a118841a8f06d6634d20b978b5a3bcf183ac
Cr-Commit-Position: refs/heads/master@{#294345}

Powered by Google App Engine
This is Rietveld 408576698