Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4)

Unified Diff: sdk/lib/_internal/compiler/js_lib/core_patch.dart

Issue 515183002: Make String.fromCharCodes take start/end. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Merge to tip of tree. Created 6 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: sdk/lib/_internal/compiler/js_lib/core_patch.dart
diff --git a/sdk/lib/_internal/compiler/js_lib/core_patch.dart b/sdk/lib/_internal/compiler/js_lib/core_patch.dart
index 441359807b8f9aa5a9941c4d73bb4bc115df0ba8..a26ee926e08377f9b1f570e7ca9b910bf7293e9c 100644
--- a/sdk/lib/_internal/compiler/js_lib/core_patch.dart
+++ b/sdk/lib/_internal/compiler/js_lib/core_patch.dart
@@ -270,11 +270,32 @@ class List<E> {
@patch
class String {
@patch
- factory String.fromCharCodes(Iterable<int> charCodes) {
- if (charCodes is! JSArray) {
- charCodes = new List.from(charCodes);
+ factory String.fromCharCodes(Iterable<int> charCodes,
+ [int start = 0, int end]) {
+ if (start < 0) throw new RangeError.value(start);
+ List list;
+ if (charCodes is JSArray) {
+ list = charCodes;
+ // If possible, recognize typed lists too.
+ int len = list.length;
+ if (end == null || end > len) end = len;
+ if (start > 0 || end < len) {
+ if (start >= end) return "";
+ list = list.sublist(start, end);
+ }
+ } else {
+ if (end != null) {
+ if (start >= end) return "";
+ charCodes = charCodes.take(end);
+ }
+ if (start > 0) charCodes = charCodes.skip(start);
+ list = charCodes.toList(); // Try the iterable's own toList first.
+ if (list is! JSArray) {
+ // If that fails, force a JSArray.
+ list = new List.from(list);
+ }
}
- return Primitives.stringFromCharCodes(charCodes);
+ return Primitives.stringFromCharCodes(list);
}
@patch

Powered by Google App Engine
This is Rietveld 408576698