Make String.fromCharCodes take start/end.

sdk/lib/convert/utf.dart

 // Copyright (c) 2013, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 part of dart.convert;
 
 /** The Unicode Replacement character `U+FFFD` (�). */
 const int UNICODE_REPLACEMENT_CHARACTER_RUNE = 0xFFFD;
 
 /** The Unicode Byte Order Marker (BOM) character `U+FEFF`. */
@@ skipping 418 matching lines @@
       for (var i = from; i < to; i++) {
         final unit = units[i];
         if ((unit & mask) != unit) return i - from;
       }
       return to - from;
     }
 
     void addSingleBytes(int from, int to) {
       assert(from >= startIndex && from <= endIndex);
       assert(to >= startIndex && to <= endIndex);
-      if (from == 0 && to == codeUnits.length) {
-        _stringSink.write(new String.fromCharCodes(codeUnits));
-      } else {
-        _stringSink.write(
-            new String.fromCharCodes(codeUnits.sublist(from, to)));
-      }
+      _stringSink.write(new String.fromCharCodes(codeUnits, from, to));
+      // if (from == 0 && to == codeUnits.length) {

[floitsch, 2014/08/29 11:13:20]

dead code?

[Søren Gjesse, 2014/08/29 11:16:04]

Code in comment.

+      //   _stringSink.write(new String.fromCharCodes(codeUnits));
+      // } else {
+      //   _stringSink.write(
+      //       new String.fromCharCodes(codeUnits.sublist(from, to)));
+      // }
     }
 
     int i = startIndex;
     loop: while (true) {
       multibyte: if (expectedUnits > 0) {
         do {
           if (i == endIndex) {
             break loop;
           }
           int unit = codeUnits[i];
@@ skipping 86 matching lines @@
       }
       break loop;
     }
     if (expectedUnits > 0) {
       _value = value;
       _expectedUnits = expectedUnits;
       _extraUnits = extraUnits;
     }
   }
 }