Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(12)

Issue 515173002: Add MachineSignature, which is an encapsulation of the machine types for parameters and return valu… (Closed)

Created:
6 years, 3 months ago by titzer
Modified:
6 years, 3 months ago
Reviewers:
Jarin
CC:
v8-dev
Project:
v8
Visibility:
Public.

Description

Add MachineSignature, which is an encapsulation of the machine types for parameters and return values in a graph. This utility will be used to simplify Linkage and fix representation inference to work with graphs where parameters and return values are something other than tagged. It will also make testing representation inference a lot easier, since we can then exactly nail down the machine types of parameters and returns. This CL also adds c-signature.h, which demonstrates how to convert C function signatures into MachineSignatures. The CSignatures will be used in tests to make it easier and simpler to codegen tests. R=jarin@chromium.org BUG= Committed: https://code.google.com/p/v8/source/detail?r=23490

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+185 lines, -37 lines) Patch
M src/compiler/change-lowering.cc View 1 chunk +1 line, -0 lines 0 comments Download
M src/compiler/linkage.h View 1 chunk +1 line, -1 line 0 comments Download
M src/compiler/linkage-impl.h View 2 chunks +2 lines, -4 lines 0 comments Download
M src/compiler/machine-operator.h View 2 chunks +1 line, -5 lines 0 comments Download
M src/compiler/machine-type.h View 1 chunk +26 lines, -0 lines 0 comments Download
M src/compiler/raw-machine-assembler.h View 1 chunk +1 line, -1 line 0 comments Download
M src/compiler/simplified-operator-reducer.cc View 1 chunk +1 line, -0 lines 0 comments Download
M src/compiler/structured-machine-assembler.h View 1 chunk +1 line, -1 line 0 comments Download
M test/cctest/cctest.gyp View 1 chunk +1 line, -0 lines 0 comments Download
A test/cctest/compiler/c-signature.h View 1 chunk +133 lines, -0 lines 0 comments Download
M test/cctest/compiler/codegen-tester.h View 1 chunk +1 line, -1 line 0 comments Download
M test/cctest/compiler/instruction-selector-tester.h View 1 chunk +1 line, -1 line 0 comments Download
M test/cctest/compiler/test-run-machops.cc View 4 chunks +10 lines, -14 lines 0 comments Download
M test/cctest/compiler/test-simplified-lowering.cc View 1 chunk +2 lines, -3 lines 0 comments Download
M test/cctest/compiler/test-structured-ifbuilder-fuzzer.cc View 1 chunk +1 line, -3 lines 0 comments Download
M test/cctest/compiler/test-structured-machine-assembler.cc View 1 chunk +2 lines, -3 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
titzer
6 years, 3 months ago (2014-08-28 11:43:12 UTC) #1
Jarin
lgtm
6 years, 3 months ago (2014-08-28 12:03:00 UTC) #2
titzer
6 years, 3 months ago (2014-08-28 13:17:56 UTC) #3
Message was sent while issue was closed.
Committed patchset #1 manually as 23490 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698