Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(40)

Issue 515153002: Add new Chrome OS key type: Salted SHA256 (Closed)

Created:
6 years, 3 months ago by bartfab (slow)
Modified:
6 years, 3 months ago
CC:
chromium-reviews, stevenjb+watch_chromium.org, oshima+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@d_2_367847_add_get_key_data_ex_call
Project:
chromium
Visibility:
Public.

Description

Add new Chrome OS key type: Salted SHA256 This CL adds a new key type for Chrome OS authentication and cryptohome encryption, a base64-encoded salted SHA256 hash. This will be the first key type supported by the credentials passing API. BUG=367847 TEST=Extended unit test Committed: https://crrev.com/28dae509e63d445a8780450f2e9152fb68ad74b8 Cr-Commit-Position: refs/heads/master@{#292924}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+31 lines, -3 lines) Patch
M chromeos/login/auth/key.h View 1 chunk +8 lines, -3 lines 0 comments Download
M chromeos/login/auth/key.cc View 1 chunk +4 lines, -0 lines 0 comments Download
M chromeos/login/auth/key_unittest.cc View 1 chunk +19 lines, -0 lines 0 comments Download

Messages

Total messages: 10 (2 generated)
bartfab (slow)
bartfab@chromium.org changed reviewers: + antrim@chromium.org
6 years, 3 months ago (2014-08-28 10:17:42 UTC) #1
bartfab (slow)
Hi Denis, Could you take a look please?
6 years, 3 months ago (2014-08-28 10:17:42 UTC) #2
bartfab (slow)
Hi Denis, Friendly review ping.
6 years, 3 months ago (2014-09-01 08:57:57 UTC) #3
bartfab (slow)
Hi Pavel, It looks like Denis may be out. Could you take a look?
6 years, 3 months ago (2014-09-02 12:29:36 UTC) #5
dzhioev (left Google)
On 2014/09/02 12:29:36, bartfab wrote: > Hi Pavel, > > It looks like Denis may ...
6 years, 3 months ago (2014-09-02 13:33:49 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/bartfab@chromium.org/515153002/1
6 years, 3 months ago (2014-09-02 13:42:11 UTC) #8
commit-bot: I haz the power
Committed patchset #1 (id:1) as 0f1ecad70597a2542150f20ea8b628b4eb28bae7
6 years, 3 months ago (2014-09-02 14:41:48 UTC) #9
commit-bot: I haz the power
6 years, 3 months ago (2014-09-10 03:18:25 UTC) #10
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/28dae509e63d445a8780450f2e9152fb68ad74b8
Cr-Commit-Position: refs/heads/master@{#292924}

Powered by Google App Engine
This is Rietveld 408576698