Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(189)

Issue 515123002: Oilpan: chrome://tracing info wrong (Closed)

Created:
6 years, 3 months ago by Daniel Chow
Modified:
6 years, 3 months ago
CC:
blink-reviews, kouhei+heap_chromium.org, Mads Ager (chromium)
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Project:
blink
Visibility:
Public.

Description

Oilpan: chrome://tracing info wrong 1. change json->setInteger("pageCount", info.freeSize); to json->setInteger("pageCount", info.pageCount); R=ager@chromium.org, oilpan-reviews@chromium.org BUG=408497 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=181073

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M Source/platform/heap/ThreadState.cpp View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 9 (0 generated)
Daniel Chow
6 years, 3 months ago (2014-08-28 10:06:02 UTC) #1
haraken
LGTM
6 years, 3 months ago (2014-08-28 10:47:41 UTC) #2
Mads Ager (chromium)
ager@chromium.org changed reviewers: + zerny@chromium.org
6 years, 3 months ago (2014-08-28 10:51:30 UTC) #3
Mads Ager (chromium)
LGTM, well spotted!
6 years, 3 months ago (2014-08-28 10:51:30 UTC) #4
zerny-chromium
LGTM. Thanks!
6 years, 3 months ago (2014-08-28 10:56:18 UTC) #5
Daniel Chow
The CQ bit was checked by zhishun.zhou@samsung.com
6 years, 3 months ago (2014-08-29 01:45:42 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/zhishun.zhou@samsung.com/515123002/1
6 years, 3 months ago (2014-08-29 01:46:04 UTC) #7
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: win_blink_rel on tryserver.blink ...
6 years, 3 months ago (2014-08-29 03:10:07 UTC) #8
commit-bot: I haz the power
6 years, 3 months ago (2014-08-29 04:01:52 UTC) #9
Message was sent while issue was closed.
Committed patchset #1 (id:1) as 181073

Powered by Google App Engine
This is Rietveld 408576698