Add more inlining unit tests.

Add more inlining unit tests.

- Scheduler can inline a function with a loop.
- Inlining strict into non-strict works correctly.
- Inlining non-strict into strict works correctly.

R=mstarzinger@chromium.org

Committed: https://code.google.com/p/v8/source/detail?r=23511

[sigurds, 2014-08-28 09:25:21]

PTAL

[Michael Starzinger, 2014-08-28 09:49:00]

https://codereview.chromium.org/515103002/diff/1/test/cctest/compiler/test-ru...
File test/cctest/compiler/test-run-inlining.cc (right):

https://codereview.chromium.org/515103002/diff/1/test/cctest/compiler/test-ru...
test/cctest/compiler/test-run-inlining.cc:234: "Object.defineProperty(obj1,
\"y\", { value: 42, writable: false });"
It seems "obj1" is never defined. This means that this line will essentially be
a no-op I think. There is a shorter way of writing this which avoid this problem
(also applies above) ...

var x = Object.create({}, { y: { value:42, writable:false } });

https://codereview.chromium.org/515103002/diff/1/test/cctest/compiler/test-ru...
test/cctest/compiler/test-run-inlining.cc:235: "function foo(s) { x.y = 9;
return 42; };"
You could use "return x.y" here as an additional verification that the
assignment really was ignored.

[sigurds, 2014-08-28 11:05:38]

https://codereview.chromium.org/515103002/diff/1/test/cctest/compiler/test-ru...
File test/cctest/compiler/test-run-inlining.cc (right):

https://codereview.chromium.org/515103002/diff/1/test/cctest/compiler/test-ru...
test/cctest/compiler/test-run-inlining.cc:234: "Object.defineProperty(obj1,
\"y\", { value: 42, writable: false });"
On 2014/08/28 09:49:00, Michael Starzinger wrote:
> It seems "obj1" is never defined. This means that this line will essentially
be
> a no-op I think. There is a shorter way of writing this which avoid this
problem
> (also applies above) ...
> 
> var x = Object.create({}, { y: { value:42, writable:false } });
That's a mistake, thanks for catching!

https://codereview.chromium.org/515103002/diff/1/test/cctest/compiler/test-ru...
test/cctest/compiler/test-run-inlining.cc:235: "function foo(s) { x.y = 9;
return 42; };"
On 2014/08/28 09:49:00, Michael Starzinger wrote:
> You could use "return x.y" here as an additional verification that the
> assignment really was ignored.

Done.

[Michael Starzinger, 2014-08-28 11:28:04]

LGTM.

[sigurds, 2014-08-29 08:59:00]

Committed patchset #3 manually as 23511 (presubmit successful).