Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(359)

Issue 515093004: chromium-cq-status: StatsTest utility class for testing CQ stats (Closed)

Created:
6 years, 3 months ago by alancutter (OOO until 2018)
Modified:
6 years, 3 months ago
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/infra/infra.git@master
Project:
infra
Visibility:
Public.

Description

chromium-cq-status: StatsTest utility class for testing CQ stats This change adds a testing utility class StatsTest. This class provides two helper functions, one for clearing all Records and one for importing Records from the contents of a JSON test resource file. New stats analysis tests will subclass StatsTest to make use of these helper functions.

Patch Set 1 #

Total comments: 2

Patch Set 2 : Rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+95 lines, -11 lines) Patch
M appengine/chromium_cq_status/handlers/query.py View 1 2 chunks +1 line, -10 lines 0 comments Download
M appengine/chromium_cq_status/model/record.py View 1 1 chunk +11 lines, -1 line 0 comments Download
A appengine/chromium_cq_status/tests/resources/test_load_records.json View 1 chunk +18 lines, -0 lines 0 comments Download
A appengine/chromium_cq_status/tests/stats_test.py View 1 chunk +65 lines, -0 lines 0 comments Download

Messages

Total messages: 7 (0 generated)
alancutter (OOO until 2018)
alancutter@chromium.org changed reviewers: + eseidel@chromium.org, jam@chromium.org, sergeyberezin@chromium.org
6 years, 3 months ago (2014-08-28 11:57:56 UTC) #1
alancutter (OOO until 2018)
6 years, 3 months ago (2014-08-28 11:58:08 UTC) #2
eseidel1
eseidel@google.com changed reviewers: + eseidel@google.com
6 years, 3 months ago (2014-08-28 16:46:32 UTC) #3
eseidel1
We shouldn't be adding new no covers.
6 years, 3 months ago (2014-08-28 16:46:32 UTC) #4
Sergey Berezin
LGTM + comment (more a question - I'm not clear on the exact meaning of ...
6 years, 3 months ago (2014-08-28 21:14:15 UTC) #5
jam
btw Sergey said he preferred I use a new app for my purposes, so I ...
6 years, 3 months ago (2014-08-28 23:13:28 UTC) #6
alancutter (OOO until 2018)
6 years, 3 months ago (2014-08-29 01:38:36 UTC) #7
If this isn't required by jam I'll put this change on hold until it actually
gets used.

https://codereview.chromium.org/515093004/diff/1/appengine/chromium_cq_status...
File appengine/chromium_cq_status/model/record.py (right):

https://codereview.chromium.org/515093004/diff/1/appengine/chromium_cq_status...
appengine/chromium_cq_status/model/record.py:9: class Record(ndb.Model): #
pragma: no cover
On 2014/08/28 21:14:15, Sergey Berezin wrote:
> Why no cover? Is it just one line, or the whole class?

Everything under appengine/ has "# pragma: no cover" because the coverage tool
run by test.py doesn't detect appengine test coverage correctly.
Without this pragma test.py will complain about no coverage despite there being
tests that run this code.

Ironically the no cover pragma is only required for apps that get tested by
test.py.

Powered by Google App Engine
This is Rietveld 408576698