Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(237)

Issue 515093003: Manual fixups in media code for scoped_refptr operator T* removal. (Closed)

Created:
6 years, 3 months ago by dcheng
Modified:
6 years, 3 months ago
CC:
chromium-reviews, darin-cc_chromium.org, feature-media-reviews_chromium.org, jam, mcasas+watch_chromium.org, posciak+watch_chromium.org, wjia+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Manual fixups in media code for scoped_refptr operator T* removal. BUG=110610 Committed: https://crrev.com/dae35047a1df7d3fa8c8937dfd7494fc8fed68f1 Cr-Commit-Position: refs/heads/master@{#292487}

Patch Set 1 #

Patch Set 2 : Simplify InspectUI #

Patch Set 3 : Remove stray file #

Patch Set 4 : Moar #

Unified diffs Side-by-side diffs Delta from patch set Stats (+24 lines, -21 lines) Patch
M content/renderer/media/media_stream_audio_source.h View 1 chunk +1 line, -1 line 0 comments Download
M content/renderer/media/media_stream_track.h View 1 chunk +3 lines, -2 lines 0 comments Download
M content/renderer/media/media_stream_track.cc View 1 chunk +3 lines, -4 lines 0 comments Download
M content/renderer/media/media_stream_video_track.cc View 1 chunk +1 line, -0 lines 0 comments Download
M content/renderer/media/video_frame_compositor_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/renderer/media/webmediaplayer_impl.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/renderer/media/webrtc_audio_renderer_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M media/filters/skcanvas_video_renderer_unittest.cc View 1 2 3 1 chunk +13 lines, -11 lines 0 comments Download

Messages

Total messages: 10 (0 generated)
dcheng
dcheng@chromium.org changed reviewers: + ddorwin@chromium.org
6 years, 3 months ago (2014-08-28 09:47:51 UTC) #1
dcheng
Manual fixups for cases the automated tool skipped. I've opted to change methods that save ...
6 years, 3 months ago (2014-08-28 09:47:51 UTC) #2
dcheng
dcheng@chromium.org changed reviewers: + scherkus@chromium.org
6 years, 3 months ago (2014-08-28 20:53:29 UTC) #3
dcheng
+scherkus, mind taking a look at this instead?
6 years, 3 months ago (2014-08-28 20:53:29 UTC) #4
scherkus (not reviewing)
rs lgtm
6 years, 3 months ago (2014-08-28 21:04:40 UTC) #5
dcheng
The CQ bit was checked by dcheng@chromium.org
6 years, 3 months ago (2014-08-28 21:18:14 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/dcheng@chromium.org/515093003/60001
6 years, 3 months ago (2014-08-28 21:19:20 UTC) #7
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: chromium_presubmit on tryserver.chromium.linux ...
6 years, 3 months ago (2014-08-28 22:49:36 UTC) #8
commit-bot: I haz the power
Committed patchset #4 (id:60001) as 210f83a3809e2c35008f0afb5551bf99a7424873
6 years, 3 months ago (2014-08-28 22:55:21 UTC) #9
commit-bot: I haz the power
6 years, 3 months ago (2014-09-10 03:03:09 UTC) #10
Message was sent while issue was closed.
Patchset 4 (id:??) landed as
https://crrev.com/dae35047a1df7d3fa8c8937dfd7494fc8fed68f1
Cr-Commit-Position: refs/heads/master@{#292487}

Powered by Google App Engine
This is Rietveld 408576698