FileAPI/sync file system cleanups for scoped_refptr operator T* cleanup.

chrome/browser/sync_file_system/drive_backend/drive_backend_sync_unittest.cc

 // Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include <algorithm>
 #include <stack>
 
 #include "base/files/file_util.h"
 #include "base/message_loop/message_loop.h"
 #include "base/run_loop.h"
@@ skipping 13 matching lines @@
 #include "chrome/browser/sync_file_system/local/local_file_sync_context.h"
 #include "chrome/browser/sync_file_system/local/local_file_sync_service.h"
 #include "chrome/browser/sync_file_system/local/sync_file_system_backend.h"
 #include "chrome/browser/sync_file_system/sync_file_system_test_util.h"
 #include "chrome/browser/sync_file_system/syncable_file_system_util.h"
 #include "chrome/test/base/testing_profile.h"
 #include "content/public/test/test_browser_thread.h"
 #include "content/public/test/test_browser_thread_bundle.h"
 #include "extensions/common/extension.h"
 #include "google_apis/drive/drive_api_parser.h"
+#include "net/url_request/url_request_context_getter.h"

[nhiroki, 2014/08/28 09:36:57]

nit: is this necessary?

[dcheng, 2014/08/28 09:40:05]

This is required, because this test instantiates a SyncEngine but passes in NULL
for the URLRequestContextGetter. Since this argument is now a const
scoped_refptr<T>&, it constructs a temporary
scoped_refptr<URLRequestContextGetter> to pass to the constructor.
Unfortunately, this needs the full definition of URLRequestContextGetter.

Another option is to move the includes to the header for SyncEngine. I'm not
sure how you would feel about that though.

[nhiroki, 2014/08/28 09:51:57]

That makes sense! Thanks for your explanation. It's ok to commit this patchset.

 #include "testing/gtest/include/gtest/gtest.h"
 #include "third_party/leveldatabase/src/helpers/memenv/memenv.h"
 #include "third_party/leveldatabase/src/include/leveldb/env.h"
 #include "webkit/browser/fileapi/file_system_context.h"
 
 #define FPL(a) FILE_PATH_LITERAL(a)
 
 namespace sync_file_system {
 namespace drive_backend {
 
@@ skipping 1677 matching lines @@
 
   EXPECT_EQ(1u, CountApp());
   EXPECT_EQ(1u, CountLocalFile(app_id));
 
   EXPECT_EQ(2u, CountMetadata());
   EXPECT_EQ(2u, CountTracker());
 }
 
 }  // namespace drive_backend
 }  // namespace sync_file_system