ServiceWorker: Change the return value of ServiceWorkerRegistration::unregister to boolean (1/4)

public/platform/WebServiceWorkerProvider.h

 /*
  * Copyright (C) 2013 Google Inc. All rights reserved.
  *
  * Redistribution and use in source and binary forms, with or without
  * modification, are permitted provided that the following conditions are
  * met:
  *
  *     * Redistributions of source code must retain the above copyright
  * notice, this list of conditions and the following disclaimer.
  *     * Redistributions in binary form must reproduce the above
@@ skipping 24 matching lines @@
 
 namespace blink {
 
 class WebString;
 class WebURL;
 class WebServiceWorker;
 class WebServiceWorkerProviderClient;
 class WebServiceWorkerRegistration;
 struct WebServiceWorkerError;
 
+#define SERVICEWORKER_UNREGISTER_DISABLE_NEW_FEATURE

[nhiroki, 2014/08/28 10:13:21]

Can you add FIXME comment and a link to the issue here?

[shimazu, 2014/08/29 07:07:07]

Done.

+
 // Created on the main thread, and may be passed to another script context
 // thread (e.g. worker thread) later. All methods of this class must be called
 // on the single script context thread.
 class WebServiceWorkerProvider {
 public:
     // Called when a client wants to start listening to the service worker
     // events. Must be cleared before the client becomes invalid.
     virtual void setClient(WebServiceWorkerProviderClient*) { }
 
     // The WebServiceWorkerRegistration and WebServiceWorkerError ownership are
     // passed to the WebServiceWorkerRegistrationCallbacks implementation.
     typedef WebCallbacks<WebServiceWorkerRegistration, WebServiceWorkerError> WebServiceWorkerRegistrationCallbacks;
+#ifdef SERVICEWORKER_UNREGISTER_DISABLE_NEW_FEATURE
+    typedef WebServiceWorkerRegistrationCallbacks WebServiceWorkerUnRegistrationCallbacks;

[nhiroki, 2014/08/28 10:13:21]

nit: s/UnRegistration/Unregistration/

[shimazu, 2014/08/29 07:07:07]

Done.

+#else
+    typedef WebCallbacks<bool, WebServiceWorkerError> WebServiceWorkerUnRegistrationCallbacks;

[nhiroki, 2014/08/28 10:13:21]

ditto.

[shimazu, 2014/08/29 07:07:07]

Done.

+#endif
 
     virtual void registerServiceWorker(const WebURL& pattern, const WebURL& scriptUrl, WebServiceWorkerRegistrationCallbacks*) { }
 
-    // Unregisters the ServiceWorker for a given scope. The provider
-    // must always pass null to onSuccess.
-    // FIXME: "unregister" does not provide a WebServiceWorkerRegistration,
-    // revisit this to clean up the the callback type to not take a
-    // WebServiceWorkerRegistration*.
-    virtual void unregisterServiceWorker(const WebURL& pattern, WebServiceWorkerRegistrationCallbacks*) { }
+    // Unregisters the ServiceWorker for a given scope.
+    virtual void unregisterServiceWorker(const WebURL& pattern, WebServiceWorkerUnRegistrationCallbacks*) { }
 
     virtual ~WebServiceWorkerProvider() { }
 };
 
 } // namespace blink
 
 #endif