Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(65)

Unified Diff: chrome/browser/chromeos/extensions/file_manager/private_api_drive.h

Issue 515033002: [fsp] Generalize fileBrowserPrivate.getEntryProperties(). (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Fixed JS files. Created 6 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/chromeos/extensions/file_manager/private_api_drive.h
diff --git a/chrome/browser/chromeos/extensions/file_manager/private_api_drive.h b/chrome/browser/chromeos/extensions/file_manager/private_api_drive.h
index 0db5964a91d58ccba61d5886c9099daae67c79db..9a277c6481381c1f2e0a77aa2991d5f73992fdac 100644
--- a/chrome/browser/chromeos/extensions/file_manager/private_api_drive.h
+++ b/chrome/browser/chromeos/extensions/file_manager/private_api_drive.h
@@ -7,6 +7,8 @@
#ifndef CHROME_BROWSER_CHROMEOS_EXTENSIONS_FILE_MANAGER_PRIVATE_API_DRIVE_H_
#define CHROME_BROWSER_CHROMEOS_EXTENSIONS_FILE_MANAGER_PRIVATE_API_DRIVE_H_
+#include "base/files/file.h"
+#include "base/memory/scoped_ptr.h"
#include "chrome/browser/chromeos/drive/file_errors.h"
#include "chrome/browser/chromeos/drive/file_system_interface.h"
#include "chrome/browser/chromeos/extensions/file_manager/private_api_base.h"
@@ -26,32 +28,35 @@ namespace extensions {
namespace api {
namespace file_browser_private {
-struct DriveEntryProperties;
+struct EntryProperties;
} // namespace file_browser_private
} // namespace api
// Retrieves property information for an entry and returns it as a dictionary.
// On error, returns a dictionary with the key "error" set to the error number
-// (drive::FileError).
-class FileBrowserPrivateGetDriveEntryPropertiesFunction
+// (base::File::Error).
+class FileBrowserPrivateGetEntryPropertiesFunction
: public LoggedAsyncExtensionFunction {
public:
- DECLARE_EXTENSION_FUNCTION("fileBrowserPrivate.getDriveEntryProperties",
- FILEBROWSERPRIVATE_GETDRIVEFILEPROPERTIES)
+ DECLARE_EXTENSION_FUNCTION("fileBrowserPrivate.getEntryProperties",
+ FILEBROWSERPRIVATE_GETENTRYPROPERTIES)
- FileBrowserPrivateGetDriveEntryPropertiesFunction();
+ FileBrowserPrivateGetEntryPropertiesFunction();
protected:
- virtual ~FileBrowserPrivateGetDriveEntryPropertiesFunction();
+ virtual ~FileBrowserPrivateGetEntryPropertiesFunction();
// AsyncExtensionFunction overrides.
virtual bool RunAsync() OVERRIDE;
private:
- void CompleteGetFileProperties(drive::FileError error);
+ void CompleteGetFileProperties(
yoshiki 2014/08/28 03:12:39 Didn't you s/FileProperties/EntryProperties/?
mtomasz 2014/08/28 05:18:51 Done.
+ size_t index,
+ scoped_ptr<api::file_browser_private::EntryProperties> properties,
+ base::File::Error error);
size_t processed_count_;
- std::vector<linked_ptr<api::file_browser_private::DriveEntryProperties> >
+ std::vector<linked_ptr<api::file_browser_private::EntryProperties> >
properties_list_;
};

Powered by Google App Engine
This is Rietveld 408576698