[fsp] Generalize fileBrowserPrivate.getEntryProperties().

[fsp] Generalize fileBrowserPrivate.getEntryProperties().

This patch makes the method providing additional metadata for entries available
for provided file systems too.

NOTRY=True
TEST=Tested manually. Files app works as before.
BUG=408017
Committed: https://crrev.com/95dc7bfd3cdd95273b6e0794ac96aef12e99b7d5
Cr-Commit-Position: refs/heads/master@{#292851}

[mtomasz, 2014-08-28 02:36:40]

mtomasz@chromium.org changed reviewers:
+ benwells@chromium.org, isherman@chromium.org, yoshiki@chromium.org

[mtomasz, 2014-08-28 02:37:21]

@yoshiki: PTAL at JS and C++.
@benwells: PTAL at IDL.
@isherman: PTAL at histograms.

Thanks.

[yoshiki, 2014-08-28 03:12:39]

lgtm with nits

https://codereview.chromium.org/515033002/diff/20001/chrome/browser/chromeos/...
File chrome/browser/chromeos/extensions/file_manager/private_api_drive.cc
(right):

https://codereview.chromium.org/515033002/diff/20001/chrome/browser/chromeos/...
chrome/browser/chromeos/extensions/file_manager/private_api_drive.cc:327: void
CompleteGetFileProperties(drive::FileError error) {
Didn't you s/FileProperties/EntryProperties/?

https://codereview.chromium.org/515033002/diff/20001/chrome/browser/chromeos/...
File chrome/browser/chromeos/extensions/file_manager/private_api_drive.h
(right):

https://codereview.chromium.org/515033002/diff/20001/chrome/browser/chromeos/...
chrome/browser/chromeos/extensions/file_manager/private_api_drive.h:53: void
CompleteGetFileProperties(
Didn't you s/FileProperties/EntryProperties/?

https://codereview.chromium.org/515033002/diff/20001/chrome/common/extensions...
File chrome/common/extensions/api/file_browser_private.idl (right):

https://codereview.chromium.org/515033002/diff/20001/chrome/common/extensions...
chrome/common/extensions/api/file_browser_private.idl:480: // |fileProperties| A
dictionary containing properties of the requested entries.
nit: fileProperies -> entryProperties

https://codereview.chromium.org/515033002/diff/20001/extensions/browser/exten...
File extensions/browser/extension_function_histogram_value.h (right):

https://codereview.chromium.org/515033002/diff/20001/extensions/browser/exten...
extensions/browser/extension_function_histogram_value.h:138:
DELETED_FILEBROWSERPRIVATE_GETDRIVEFILEPROPERTIES,
You can keep using this entry in renaming case (see the rule #3 in l.43 in this
file)

[Ilya Sherman, 2014-08-28 03:50:44]

histograms lgtm

[mtomasz, 2014-08-28 05:18:52]

https://codereview.chromium.org/515033002/diff/20001/chrome/browser/chromeos/...
File chrome/browser/chromeos/extensions/file_manager/private_api_drive.cc
(right):

https://codereview.chromium.org/515033002/diff/20001/chrome/browser/chromeos/...
chrome/browser/chromeos/extensions/file_manager/private_api_drive.cc:327: void
CompleteGetFileProperties(drive::FileError error) {
On 2014/08/28 03:12:39, yoshiki wrote:
> Didn't you s/FileProperties/EntryProperties/?

Done.

https://codereview.chromium.org/515033002/diff/20001/chrome/browser/chromeos/...
File chrome/browser/chromeos/extensions/file_manager/private_api_drive.h
(right):

https://codereview.chromium.org/515033002/diff/20001/chrome/browser/chromeos/...
chrome/browser/chromeos/extensions/file_manager/private_api_drive.h:53: void
CompleteGetFileProperties(
On 2014/08/28 03:12:39, yoshiki wrote:
> Didn't you s/FileProperties/EntryProperties/?

Done.

https://codereview.chromium.org/515033002/diff/20001/chrome/common/extensions...
File chrome/common/extensions/api/file_browser_private.idl (right):

https://codereview.chromium.org/515033002/diff/20001/chrome/common/extensions...
chrome/common/extensions/api/file_browser_private.idl:480: // |fileProperties| A
dictionary containing properties of the requested entries.
On 2014/08/28 03:12:39, yoshiki wrote:
> nit: fileProperies -> entryProperties

Done.

https://codereview.chromium.org/515033002/diff/20001/extensions/browser/exten...
File extensions/browser/extension_function_histogram_value.h (right):

https://codereview.chromium.org/515033002/diff/20001/extensions/browser/exten...
extensions/browser/extension_function_histogram_value.h:138:
DELETED_FILEBROWSERPRIVATE_GETDRIVEFILEPROPERTIES,
On 2014/08/28 03:12:39, yoshiki wrote:
> You can keep using this entry in renaming case (see the rule #3 in l.43 in
this
> file)

Good point. Fixed.

[benwells, 2014-09-01 01:33:53]

idl lgtm

[mtomasz, 2014-09-01 03:54:19]

The CQ bit was checked by mtomasz@chromium.org

[commit-bot: I haz the power, 2014-09-01 03:54:30]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/mtomasz@chromium.org/515033002/40001

[commit-bot: I haz the power, 2014-09-01 04:52:00]

FYI, CQ is re-trying this CL (attempt #1).
The failing builders are:
  chromium_presubmit on tryserver.chromium.linux
(http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)

[commit-bot: I haz the power, 2014-09-01 04:55:55]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-09-01 04:55:56]

Try jobs failed on following builders:
  chromium_presubmit on tryserver.chromium.linux
(http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)

[mtomasz, 2014-09-01 08:49:57]

The CQ bit was checked by mtomasz@chromium.org

[commit-bot: I haz the power, 2014-09-01 08:51:02]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/mtomasz@chromium.org/515033002/60001

[commit-bot: I haz the power, 2014-09-01 08:52:17]

Committed patchset #4 (id:60001) as 5cff73419a6efbefb0d1b177a6026ceab24c60e4

[commit-bot: I haz the power, 2014-09-10 03:16:08]

Patchset 4 (id:??) landed as
https://crrev.com/95dc7bfd3cdd95273b6e0794ac96aef12e99b7d5
Cr-Commit-Position: refs/heads/master@{#292851}