Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(278)

Unified Diff: ui/events/ozone/evdev/libgestures_glue/gesture_interpreter_libevdev_cros.cc

Issue 514943003: ozone: evdev: gestures: Disable click when the cursor is hidden (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 6 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « ui/events/ozone/evdev/cursor_delegate_evdev.h ('k') | ui/ozone/platform/dri/cursor_factory_evdev_dri.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: ui/events/ozone/evdev/libgestures_glue/gesture_interpreter_libevdev_cros.cc
diff --git a/ui/events/ozone/evdev/libgestures_glue/gesture_interpreter_libevdev_cros.cc b/ui/events/ozone/evdev/libgestures_glue/gesture_interpreter_libevdev_cros.cc
index 3789dc91835e6dfa5caf08d06ed330338e0778dd..e49082bd88b8645a6be0099faed2c2056f31b264 100644
--- a/ui/events/ozone/evdev/libgestures_glue/gesture_interpreter_libevdev_cros.cc
+++ b/ui/events/ozone/evdev/libgestures_glue/gesture_interpreter_libevdev_cros.cc
@@ -254,6 +254,14 @@ void GestureInterpreterLibevdevCros::OnGestureButtonsChange(
if (!cursor_)
return; // No cursor!
+ // HACK for disabling TTC (actually, all clicks) on hidden cursor.
+ // This is normally plumbed via properties and can be removed soon.
+ // TODO(spang): Remove this.
+ if (buttons->down == GESTURES_BUTTON_LEFT &&
+ buttons->up == GESTURES_BUTTON_LEFT &&
+ !cursor_->IsCursorVisible())
+ return;
+
// TODO(spang): Use buttons->start_time, buttons->end_time
if (buttons->down & GESTURES_BUTTON_LEFT)
DispatchMouseButton(EVDEV_MODIFIER_LEFT_MOUSE_BUTTON, true);
« no previous file with comments | « ui/events/ozone/evdev/cursor_delegate_evdev.h ('k') | ui/ozone/platform/dri/cursor_factory_evdev_dri.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698