Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(290)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 51493003: Fix app_list_unittests win static library compile. (Closed)

Created:
7 years, 1 month ago by xiyuan
Modified:
7 years, 1 month ago
CC:
chromium-reviews, chrome-apps-syd-reviews_chromium.org, tfarina
Visibility:
Public.

Description

Fix app_list_unittests win static library compile. BUG=310636 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=232866

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -0 lines) Patch
M ui/app_list/app_list.gyp View 1 chunk +5 lines, -0 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
xiyuan
sebmarchand@ has tried it and seems working. :)
7 years, 1 month ago (2013-11-04 19:01:21 UTC) #1
Sébastien Marchand
lgtm lgtm (I'm not a committer). I've just tried to build this target locally: set ...
7 years, 1 month ago (2013-11-04 19:03:48 UTC) #2
commit-bot: I haz the power
No LGTM from a valid reviewer yet. Only full committers are accepted. Even if an ...
7 years, 1 month ago (2013-11-04 19:14:14 UTC) #3
stevenjb
lgtm
7 years, 1 month ago (2013-11-04 19:24:44 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/xiyuan@chromium.org/51493003/1
7 years, 1 month ago (2013-11-04 19:41:31 UTC) #5
commit-bot: I haz the power
7 years, 1 month ago (2013-11-05 01:04:26 UTC) #6
Message was sent while issue was closed. 
Change committed as 232866

Powered by Google App Engine
This is Rietveld 408576698