Add more generic filters to the chrome.hid.getDevices API.

Add more generic filters to the chrome.hid.getDevices API.

Instead of specifying each of the USB vendor and product ID pairs an
app has permission to open this API extension allows filtering of
devices by vendor and product IDs as well as HID usage pages and
usages. The 'vendorId' and 'productId' properties of GetDevicesOptions
are still supported for backwards compatibility.

BUG=

Committed: https://crrev.com/f4dc9d143de2350fc4879c178059737997944016
Cr-Commit-Position: refs/heads/master@{#292577}

[Reilly Grant (use Gerrit), 2014-08-27 20:24:33]

reillyg@chromium.org changed reviewers:
+ juanlang@chromium.org, kalman@chromium.org, mschilder@chromium.org,
rockot@chromium.org

[juanlang (chromium.org), 2014-08-28 22:32:50]

lgtm

[Ken Rockot(use gerrit already), 2014-08-28 22:48:10]

I reviewed this yesterday and for some reason didn't stamp it. I don't remember
why and cannot find a good reason now. So lgtm!

https://codereview.chromium.org/514923002/diff/1/device/hid/hid_device_filter.cc
File device/hid/hid_device_filter.cc (right):

https://codereview.chromium.org/514923002/diff/1/device/hid/hid_device_filter...
device/hid/hid_device_filter.cc:75: /* static */ bool
HidDeviceFilter::MatchesAny(
/* static */ on its own line.

[Ken Rockot(use gerrit already), 2014-08-28 22:48:30]

> /* static */ on its own line.

Err, I mean // static

[Reilly Grant (use Gerrit), 2014-08-28 22:52:12]

Patchset #2 (id:20001) has been deleted

[not at google - send to devlin, 2014-08-28 23:12:09]

https://codereview.chromium.org/514923002/diff/40001/extensions/common/api/hi...
File extensions/common/api/hid.idl (right):

https://codereview.chromium.org/514923002/diff/40001/extensions/common/api/hi...
extensions/common/api/hid.idl:57: HidDeviceFilter[]? filters;
Are you leaving |vendorId| and |productId| in this structure for backwards
compatibility? Since they could be modelled as a filter, right?

[Reilly Grant (use Gerrit), 2014-08-28 23:13:09]

https://codereview.chromium.org/514923002/diff/40001/extensions/common/api/hi...
File extensions/common/api/hid.idl (right):

https://codereview.chromium.org/514923002/diff/40001/extensions/common/api/hi...
extensions/common/api/hid.idl:57: HidDeviceFilter[]? filters;
On 2014/08/28 23:12:08, kalman wrote:
> Are you leaving |vendorId| and |productId| in this structure for backwards
> compatibility? Since they could be modelled as a filter, right?

Yes, the implementation creates a filter to model them if they are given.

[not at google - send to devlin, 2014-08-28 23:18:36]

https://codereview.chromium.org/514923002/diff/40001/extensions/common/api/hi...
File extensions/common/api/hid.idl (right):

https://codereview.chromium.org/514923002/diff/40001/extensions/common/api/hi...
extensions/common/api/hid.idl:57: HidDeviceFilter[]? filters;
On 2014/08/28 23:13:09, reillyg wrote:
> On 2014/08/28 23:12:08, kalman wrote:
> > Are you leaving |vendorId| and |productId| in this structure for backwards
> > compatibility? Since they could be modelled as a filter, right?
> 
> Yes, the implementation creates a filter to model them if they are given.

It's a shame to see the HID API reach this far and then have this change made
just for backwards compatibility. Should you be deprecating the old properties?

Also: please document everything you've added here.

[Reilly Grant (use Gerrit), 2014-08-29 00:16:13]

On 2014/08/28 23:18:36, kalman wrote:
>
https://codereview.chromium.org/514923002/diff/40001/extensions/common/api/hi...
> File extensions/common/api/hid.idl (right):
> 
>
https://codereview.chromium.org/514923002/diff/40001/extensions/common/api/hi...
> extensions/common/api/hid.idl:57: HidDeviceFilter[]? filters;
> On 2014/08/28 23:13:09, reillyg wrote:
> > On 2014/08/28 23:12:08, kalman wrote:
> > > Are you leaving |vendorId| and |productId| in this structure for backwards
> > > compatibility? Since they could be modelled as a filter, right?
> > 
> > Yes, the implementation creates a filter to model them if they are given.
> 
> It's a shame to see the HID API reach this far and then have this change made
> just for backwards compatibility. Should you be deprecating the old
properties?
> 
> Also: please document everything you've added here.

I've marked the properties as deprecated in the documentation and explain that
they are equivalent to providing a filter.

[not at google - send to devlin, 2014-08-29 00:26:27]

lgtm, but check that everything looks good using

https://developer.chrome.com/_patch/514923002/apps/hid

or

chrome/common/extensions/docs/server2/preview.py

if that decides not to work.

https://codereview.chromium.org/514923002/diff/60001/extensions/common/api/hi...
File extensions/common/api/hid.idl (right):

https://codereview.chromium.org/514923002/diff/60001/extensions/common/api/hi...
extensions/common/api/hid.idl:51: // (checked only if the HID usage page
matches)
This is all going to be generated as https://developer.chrome.com/apps/hid -
these comment in parenthesis are useful but would look better as part of a whole
document.

I don't know much about this stuff, but it seems like if certain properties are
only checked in certain conditions... this filter is a match-everything-specific
type thing?

https://codereview.chromium.org/514923002/diff/60001/extensions/common/api/hi...
extensions/common/api/hid.idl:59: long? vendorId;
There's a deprecated annotation:

[deprecated=Use a filter with $(ref:hid.DeviceFilter.vendorId vendorId)]

likewise.

[Reilly Grant (use Gerrit), 2014-08-29 01:02:18]

I've looked through the generated documentation and made a number of
improvements.

[Reilly Grant (use Gerrit), 2014-08-29 01:17:29]

The CQ bit was checked by reillyg@chromium.org

[commit-bot: I haz the power, 2014-08-29 01:19:04]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/reillyg@chromium.org/514923002/80001

[commit-bot: I haz the power, 2014-08-29 05:53:03]

Committed patchset #4 (id:80001) as 1816af67d3fb992ff49fb22b2b8fc8908d6ee6b1

[commit-bot: I haz the power, 2014-09-10 03:06:36]

Patchset 4 (id:??) landed as
https://crrev.com/f4dc9d143de2350fc4879c178059737997944016
Cr-Commit-Position: refs/heads/master@{#292577}