Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(349)

Unified Diff: pkg/observe/lib/src/observable_map.dart

Issue 51483002: fix PathObserver to avoid try+catch (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: rm meta Created 7 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: pkg/observe/lib/src/observable_map.dart
diff --git a/pkg/observe/lib/src/observable_map.dart b/pkg/observe/lib/src/observable_map.dart
index d4da6461725ed7fa29f5f4b7293f1a033523a232..27e25da27c3632e07fc22faf7da86414e858f202 100644
--- a/pkg/observe/lib/src/observable_map.dart
+++ b/pkg/observe/lib/src/observable_map.dart
@@ -2,7 +2,11 @@
// for details. All rights reserved. Use of this source code is governed by a
// BSD-style license that can be found in the LICENSE file.
-part of observe;
+library observe.src.observable_map;
+
+import 'dart:collection';
+import 'package:observe/observe.dart';
+
// TODO(jmesserly): this needs to be faster. We currently require multiple
// lookups per key to get the old value.
@@ -34,14 +38,10 @@ class MapChangeRecord<K, V> extends ChangeRecord {
: isInsert = false, isRemove = false;
MapChangeRecord.insert(this.key, this.newValue)
- : isInsert = true, isRemove = false;
+ : isInsert = true, isRemove = false, oldValue = null;
MapChangeRecord.remove(this.key, this.oldValue)
- : isInsert = false, isRemove = true;
-
- /// *Deprecated* compare [key]s instead.
- @deprecated
- bool changes(otherKey) => key == otherKey;
+ : isInsert = false, isRemove = true, newValue = null;
String toString() {
var kind = isInsert ? 'insert' : isRemove ? 'remove' : 'set';
@@ -76,10 +76,11 @@ class ObservableMap<K, V> extends ChangeNotifier implements Map<K, V> {
* you should use [toObservable].
*/
factory ObservableMap.from(Map<K, V> other) {
- return new ObservableMap<K, V>._createFromType(other)..addAll(other);
+ return new ObservableMap<K, V>.createFromType(other)..addAll(other);
}
- factory ObservableMap._createFromType(Map<K, V> other) {
+ /** Like [ObservableMap.from], but creates an empty map. */
+ factory ObservableMap.createFromType(Map<K, V> other) {
ObservableMap result;
if (other is SplayTreeMap) {
result = new ObservableMap<K, V>.sorted();

Powered by Google App Engine
This is Rietveld 408576698