Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(515)

Issue 514783002: Fix serialization references to Cell objects. (Closed)

Created:
6 years, 3 months ago by Slava Chigrin
Modified:
6 years, 3 months ago
Reviewers:
Yang
CC:
v8-dev
Visibility:
Public.

Description

Fix serialization references to Cell objects. R=yangguo@chromium.org Committed: https://code.google.com/p/v8/source/detail?r=23484

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -0 lines) Patch
M src/serialize.cc View 1 chunk +1 line, -0 lines 1 comment Download

Messages

Total messages: 11 (0 generated)
Slava Chigrin
vchigrin@yandex-team.ru changed reviewers: + yangguo@chromium.org
6 years, 3 months ago (2014-08-27 17:46:05 UTC) #1
Slava Chigrin
https://codereview.chromium.org/514783002/diff/1/src/serialize.cc File src/serialize.cc (right): https://codereview.chromium.org/514783002/diff/1/src/serialize.cc#newcode1640 src/serialize.cc:1640: } Seems, this increment was missed, so pointers go ...
6 years, 3 months ago (2014-08-27 17:47:13 UTC) #2
Yang
On 2014/08/27 17:47:13, Slava Chigrin wrote: > https://codereview.chromium.org/514783002/diff/1/src/serialize.cc > File src/serialize.cc (right): > > https://codereview.chromium.org/514783002/diff/1/src/serialize.cc#newcode1640 ...
6 years, 3 months ago (2014-08-28 09:54:06 UTC) #3
Slava Chigrin
The CQ bit was checked by vchigrin@yandex-team.ru
6 years, 3 months ago (2014-08-28 09:57:08 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://v8-status.appspot.com/cq/vchigrin@yandex-team.ru/514783002/1
6 years, 3 months ago (2014-08-28 09:57:26 UTC) #5
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 3 months ago (2014-08-28 09:57:27 UTC) #6
commit-bot: I haz the power
No LGTM from a valid reviewer yet. Only full committers are accepted. Even if an ...
6 years, 3 months ago (2014-08-28 09:57:28 UTC) #7
Yang
On 2014/08/28 09:57:28, I haz the power (commit-bot) wrote: > No LGTM from a valid ...
6 years, 3 months ago (2014-08-28 10:30:17 UTC) #8
Slava Chigrin
On 2014/08/28 10:30:17, Yang wrote: > On 2014/08/28 09:57:28, I haz the power (commit-bot) wrote: ...
6 years, 3 months ago (2014-08-28 10:38:09 UTC) #9
Yang
On 2014/08/28 10:38:09, Slava Chigrin wrote: > On 2014/08/28 10:30:17, Yang wrote: > > On ...
6 years, 3 months ago (2014-08-28 10:39:12 UTC) #10
Yang
6 years, 3 months ago (2014-08-28 10:51:51 UTC) #11
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as 23484 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698