Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(185)

Issue 514773002: Revert of Used native deinterleaved and float point format for the input streams. (Closed)

Created:
6 years, 3 months ago by no longer working on chromium
Modified:
6 years, 3 months ago
Reviewers:
eroman, DaleCurtis
CC:
chromium-reviews, feature-media-reviews_chromium.org
Project:
chromium
Visibility:
Public.

Description

Revert of Used native deinterleaved and float point format for the input streams. (patchset #5 of https://codereview.chromium.org/501823002/) Reason for revert: It broke the mac asan bot, http://build.chromium.org/p/chromium.memory/builders/Mac%20ASan%2064%20Tests%20%281%29/builds/1976 Original issue's description: > Used native deinterleaved and float point format for the input streams. > > If we call GetProperty of kAudioUnitProperty_StreamFormat before setting the format, the device will report kAudioFormatFlagsNativeFloatPacked | kLinearPCMFormatFlagIsNonInterleaved as the native format of the device, which is the same as the output. > > This patch changes the format to use kAudioFormatFlagsNativeFloatPacked | kLinearPCMFormatFlagIsNonInterleaved to open the device, so that we will avoid format flipping back and forth. Hope this optimization will help increase the stability of the input audio on Mac. > > > BUG=404884 > TEST=media_unittests && https://webrtc.googlecode.com/svn-history/r5497/trunk/samples/js/demos/html/pc1.html, https://www.google.com/intl/en/chrome/demos/speech.html > > Committed: https://chromium.googlesource.com/chromium/src/+/1a9ce977642c7f2cc2e30d83757c42264f052f0b TBR=dalecurtis@chromium.org,eroman@chromium.org NOTREECHECKS=true NOTRY=true BUG=404884 Committed: https://crrev.com/f9872e1a026bfe61e12ae84087fdf142b0d407b6 Cr-Commit-Position: refs/heads/master@{#292176}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+144 lines, -211 lines) Patch
M media/audio/mac/audio_low_latency_input_mac.h View 5 chunks +10 lines, -11 lines 0 comments Download
M media/audio/mac/audio_low_latency_input_mac.cc View 16 chunks +100 lines, -108 lines 0 comments Download
M media/base/audio_block_fifo.h View 2 chunks +0 lines, -7 lines 0 comments Download
M media/base/audio_block_fifo.cc View 3 chunks +8 lines, -38 lines 0 comments Download
M media/base/audio_block_fifo_unittest.cc View 6 chunks +26 lines, -47 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
no longer working on chromium
Created Revert of Used native deinterleaved and float point format for the input streams.
6 years, 3 months ago (2014-08-27 17:26:47 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/xians@chromium.org/514773002/1
6 years, 3 months ago (2014-08-27 17:27:43 UTC) #2
commit-bot: I haz the power
Committed patchset #1 (id:1) as b35b492ebfc2446a06428963ac4dcc0f583059f3
6 years, 3 months ago (2014-08-27 17:28:39 UTC) #3
commit-bot: I haz the power
6 years, 3 months ago (2014-09-10 02:52:30 UTC) #4
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/f9872e1a026bfe61e12ae84087fdf142b0d407b6
Cr-Commit-Position: refs/heads/master@{#292176}

Powered by Google App Engine
This is Rietveld 408576698