add gamma/sRGB to SkImageInfo

add gamma/sRGB to SkImageInfo

BUG=skia:

Committed: https://skia.googlesource.com/skia/+/615c369777258231054840a88cdb74c68c382485

[reed1, 2014-08-27 16:16:31]

reed@google.com changed reviewers:
+ bsalomon@google.com, bungeman@google.com

[reed1, 2014-08-27 16:16:31]

Open questions:

1. What is gamma() of an Unknown info?
2. What is gamma() of an sRGB?
3. What is gamma() of a legacy (unspecified) info (even a RGB one)?

Today the code returns 0 for all of those, but perhaps that isn't best.

Another question:

4. Should we explicitly expose Profile?

[bsalomon, 2014-08-27 17:11:31]

I think:

1) 0
2) 0
3) Not sure, depends on what our current impl does.
4) Not unless we need to.

https://codereview.chromium.org/514753002/diff/1/include/core/SkImageInfo.h
File include/core/SkImageInfo.h (right):

https://codereview.chromium.org/514753002/diff/1/include/core/SkImageInfo.h#n...
include/core/SkImageInfo.h:158: static SkImageInfo MakeWithGamam(int width, int
height, SkColorType ct, SkAlphaType at,
typo, gamam

https://codereview.chromium.org/514753002/diff/1/src/core/SkImageInfo.cpp
File src/core/SkImageInfo.cpp (right):

https://codereview.chromium.org/514753002/diff/1/src/core/SkImageInfo.cpp#new...
src/core/SkImageInfo.cpp:24: return true;
// case kLuminance:

[bungeman-skia, 2014-08-27 18:08:52]

gamma() returning  0 for unknown, but then being able to discriminate by using
isSRGB alleviates some potential issues.

https://codereview.chromium.org/514753002/diff/1/src/core/SkImageInfo.cpp
File src/core/SkImageInfo.cpp (right):

https://codereview.chromium.org/514753002/diff/1/src/core/SkImageInfo.cpp#new...
src/core/SkImageInfo.cpp:46: const float max_gamma = 100.0f;
I actually currently have a max of 4.0 - epsilon over in SkScalerContextRec. It
seems difficult to justify a gamma even that big, the highest number I've ever
seen in actual use is PAL with 2.8.

[reed1, 2014-08-27 18:52:49]

https://codereview.chromium.org/514753002/diff/1/include/core/SkImageInfo.h
File include/core/SkImageInfo.h (right):

https://codereview.chromium.org/514753002/diff/1/include/core/SkImageInfo.h#n...
include/core/SkImageInfo.h:158: static SkImageInfo MakeWithGamam(int width, int
height, SkColorType ct, SkAlphaType at,
On 2014/08/27 17:11:30, bsalomon wrote:
> typo, gamam

Done.

https://codereview.chromium.org/514753002/diff/1/src/core/SkImageInfo.cpp
File src/core/SkImageInfo.cpp (right):

https://codereview.chromium.org/514753002/diff/1/src/core/SkImageInfo.cpp#new...
src/core/SkImageInfo.cpp:24: return true;
On 2014/08/27 17:11:30, bsalomon wrote:
> // case kLuminance:

Done.

https://codereview.chromium.org/514753002/diff/1/src/core/SkImageInfo.cpp#new...
src/core/SkImageInfo.cpp:46: const float max_gamma = 100.0f;
On 2014/08/27 18:08:52, bungeman1 wrote:
> I actually currently have a max of 4.0 - epsilon over in SkScalerContextRec.
It
> seems difficult to justify a gamma even that big, the highest number I've ever
> seen in actual use is PAL with 2.8.

Done.

[reed1, 2014-08-27 18:58:14]

next iteration...

[bungeman-skia, 2014-08-27 19:48:24]

lgtm with nit

https://codereview.chromium.org/514753002/diff/20001/include/core/SkImageInfo.h
File include/core/SkImageInfo.h (right):

https://codereview.chromium.org/514753002/diff/20001/include/core/SkImageInfo...
include/core/SkImageInfo.h:177: *  Not that if the requested gamma is
unsupported for the requested color type, then the gamma
Not[e]

[bsalomon, 2014-08-27 19:50:23]

lgtm

[reed1, 2014-08-27 20:28:05]

The CQ bit was checked by reed@google.com

[reed1, 2014-08-27 20:28:06]

The CQ bit was unchecked by reed@google.com

[reed1, 2014-08-27 20:29:10]

The CQ bit was checked by reed@google.com

[commit-bot: I haz the power, 2014-08-27 20:29:23]

CQ is trying da patch. Follow status at
 https://skia-tree-status.appspot.com/cq/reed@google.com/514753002/40001

[reed1, 2014-08-27 20:30:34]

The CQ bit was unchecked by reed@google.com

[reed1, 2014-08-27 20:30:48]

oops, need to bump the bloody picture format...

[reed1, 2014-08-28 00:35:58]

no need to bump picture format after all.

[reed1, 2014-08-28 12:44:50]

The CQ bit was checked by reed@google.com

[commit-bot: I haz the power, 2014-08-28 12:44:56]

CQ is trying da patch. Follow status at
 https://skia-tree-status.appspot.com/cq/reed@google.com/514753002/60001

[commit-bot: I haz the power, 2014-08-28 12:56:42]

Committed patchset #4 (id:60001) as 615c369777258231054840a88cdb74c68c382485

[reed1, 2014-08-28 13:52:30]

A revert of this CL (patchset #4) has been created in
https://codereview.chromium.org/512243002/ by reed@google.com.

The reason for reverting is: breaks linker on chrome -- may need SK_API, but not
sure..