Issue 514723004: Subzero: Fix the link command for Trusty.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 514723004: Subzero: Fix the link command for Trusty. (Closed)

Created:
6 years, 3 months ago by Jim Stichnoth

Modified:
6 years, 3 months ago

Reviewers:
jvoung (off chromium)

CC:
native-client-reviews_googlegroups.com

Base URL:
https://gerrit.chromium.org/gerrit/p/native_client/pnacl-subzero.git@master

Visibility:
Public.

More Reviews

Description

Subzero: Fix the link command for Trusty. With the original link command, -lpthread comes before some other LLVM libraries, and this ends up causing undefined pthreads symbols. The new link command makes sure the -lpthread part comes last. BUG= none R=jvoung@chromium.org Committed: https://gerrit.chromium.org/gerrit/gitweb?p=native_client/pnacl-subzero.git;a=commit;h=14c3f41

Patch Set 1 #

Total comments: 1

Created: 6 years, 3 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+2 lines, -1 line)			Patch
	M	Makefile.standalone	View		1 chunk	+2 lines, -1 line	1 comment	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

Jim Stichnoth

stichnot@chromium.org changed reviewers: + jvoung@chromium.org

6 years, 3 months ago (2014-08-27 17:49:24 UTC) #1

jvoung (off chromium)

LGTM https://codereview.chromium.org/514723004/diff/1/Makefile.standalone File Makefile.standalone (right): https://codereview.chromium.org/514723004/diff/1/Makefile.standalone#newcode38 Makefile.standalone:38: `$(LLVM_BIN_PATH)/llvm-config --ldflags` Just heads up -- I think ...

6 years, 3 months ago (2014-08-27 17:55:19 UTC) #3

Jim Stichnoth

6 years, 3 months ago (2014-08-27 18:02:54 UTC) #4

Message was sent while issue was closed.

Committed patchset #1 (id:1) manually as 14c3f41 (presubmit successful).

Expand Messages | Collapse Messages