Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(126)

Issue 514653003: GuestView: Cleanup on Embedder process swap (Closed)

Created:
6 years, 3 months ago by Fady Samuel
Modified:
6 years, 3 months ago
Reviewers:
lazyboy
CC:
chromium-reviews, chromium-apps-reviews_chromium.org, extensions-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

GuestView: Cleanup on Embedder process swap BUG=408688 Test=Launch chrome://extensions with --enable-embedded-extension-options, open SPDY options, navigate to www.google.com, the "Options: SPDY Proxy Extension Options" entry should disappear from the Task Manager. Committed: https://crrev.com/01fcc507ca7ff1686042b237c6b853a463edcf76 Cr-Commit-Position: refs/heads/master@{#292505}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -0 lines) Patch
M extensions/browser/guest_view/guest_view_base.cc View 1 chunk +6 lines, -0 lines 0 comments Download

Messages

Total messages: 7 (0 generated)
Fady Samuel
fsamuel@chromium.org changed reviewers: + lazyboy@chromium.org
6 years, 3 months ago (2014-08-28 18:46:56 UTC) #1
Fady Samuel
6 years, 3 months ago (2014-08-28 18:46:56 UTC) #2
lazyboy
lgtm Add a Test= section to the CL describing how the behavior can be tested, ...
6 years, 3 months ago (2014-08-28 18:50:27 UTC) #3
Fady Samuel
The CQ bit was checked by fsamuel@chromium.org
6 years, 3 months ago (2014-08-28 18:53:57 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/fsamuel@chromium.org/514653003/1
6 years, 3 months ago (2014-08-28 18:55:21 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1) as 6748658c42a6a82eb4d53f92fc94cb77a48bb7c0
6 years, 3 months ago (2014-08-28 23:51:13 UTC) #6
commit-bot: I haz the power
6 years, 3 months ago (2014-09-10 03:03:48 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/01fcc507ca7ff1686042b237c6b853a463edcf76
Cr-Commit-Position: refs/heads/master@{#292505}

Powered by Google App Engine
This is Rietveld 408576698