Issue 514643002: [turbofan] Explicitly mark call sites as patchable.

Issue 514643002: [turbofan] Explicitly mark call sites as patchable. (Closed)

Created:
6 years, 3 months ago by Benedikt Meurer

Modified:
6 years, 3 months ago

Reviewers:
Michael Starzinger

CC:
v8-dev

Base URL:
https://v8.googlecode.com/svn/branches/bleeding_edge

Project:
v8

Visibility:
Public.

More Reviews

Description

[turbofan] Explicitly mark call sites as patchable. TEST=cctest,mjsunit R=mstarzinger@chromium.org Committed: https://code.google.com/p/v8/source/detail?r=23506

Patch Set 2 : Address comments #

Patch Set 3 : REBASE #

Created: 6 years, 3 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+170 lines, -160 lines)			Patch
M	src/compiler/arm/code-generator-arm.cc	View	1	1 chunk	+4 lines, -4 lines	0 comments	Download
M	src/compiler/arm/instruction-selector-arm.cc	View		1 chunk	+1 line, -1 line	0 comments	Download
M	src/compiler/arm/linkage-arm.cc	View		1 chunk	+8 lines, -7 lines	0 comments	Download
M	src/compiler/arm64/code-generator-arm64.cc	View	1	1 chunk	+0 lines, -2 lines	0 comments	Download
M	src/compiler/arm64/instruction-selector-arm64.cc	View		1 chunk	+1 line, -1 line	0 comments	Download
M	src/compiler/arm64/linkage-arm64.cc	View		1 chunk	+8 lines, -7 lines	0 comments	Download
M	src/compiler/code-generator.cc	View	1	2 chunks	+7 lines, -5 lines	0 comments	Download
M	src/compiler/ia32/code-generator-ia32.cc	View	1	2 chunks	+3 lines, -4 lines	0 comments	Download
M	src/compiler/ia32/instruction-selector-ia32.cc	View		1 chunk	+1 line, -1 line	0 comments	Download
M	src/compiler/ia32/linkage-ia32.cc	View		2 chunks	+12 lines, -10 lines	0 comments	Download
M	src/compiler/js-generic-lowering.h	View		2 chunks	+6 lines, -4 lines	0 comments	Download
M	src/compiler/js-generic-lowering.cc	View	1 2	14 chunks	+54 lines, -46 lines	0 comments	Download
M	src/compiler/linkage.h	View	1	7 chunks	+31 lines, -34 lines	0 comments	Download
M	src/compiler/linkage.cc	View		3 chunks	+15 lines, -14 lines	0 comments	Download
M	src/compiler/linkage-impl.h	View		6 chunks	+10 lines, -11 lines	0 comments	Download
M	src/compiler/x64/code-generator-x64.cc	View	1	1 chunk	+0 lines, -1 line	0 comments	Download
M	src/compiler/x64/instruction-selector-x64.cc	View		1 chunk	+1 line, -1 line	0 comments	Download
M	src/compiler/x64/linkage-x64.cc	View		1 chunk	+8 lines, -7 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

Michael Starzinger

LGTM with nits. https://codereview.chromium.org/514643002/diff/1/src/compiler/arm64/code-generator-arm64.cc File src/compiler/arm64/code-generator-arm64.cc (left): https://codereview.chromium.org/514643002/diff/1/src/compiler/arm64/code-generator-arm64.cc#oldcode150 src/compiler/arm64/code-generator-arm64.cc:150: AddNopForSmiCodeInlining(); Yeah! You are my hero. ...

6 years, 3 months ago (2014-08-27 12:50:11 UTC) #2

Benedikt Meurer

https://codereview.chromium.org/514643002/diff/1/src/compiler/js-generic-lowering.cc File src/compiler/js-generic-lowering.cc (right): https://codereview.chromium.org/514643002/diff/1/src/compiler/js-generic-lowering.cc#newcode224 src/compiler/js-generic-lowering.cc:224: ReplaceWithStubCall(node, &stub, CallDescriptor::kPatchableCallSite | \ On 2014/08/27 12:50:11, Michael ...

6 years, 3 months ago (2014-08-28 11:46:57 UTC) #3

Benedikt Meurer

6 years, 3 months ago (2014-08-29 05:03:19 UTC) #4

Message was sent while issue was closed.

Committed patchset #3 manually as 23506 (presubmit successful).

Expand Messages | Collapse Messages