Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(127)

Issue 514613002: Remove false checks since GetOwnProperty now throws an exception on access check violation. (Closed)

Created:
6 years, 3 months ago by Toon Verwaest
Modified:
6 years, 3 months ago
Reviewers:
Yang
CC:
v8-dev
Project:
v8
Visibility:
Public.

Description

Remove false checks since GetOwnProperty now throws an exception on access check violation. BUG= R=yangguo@chromium.org Committed: https://code.google.com/p/v8/source/detail?r=23452

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -12 lines) Patch
M src/v8natives.js View 3 chunks +2 lines, -12 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
Toon Verwaest
verwaest@chromium.org changed reviewers: + yangguo@chromium.org
6 years, 3 months ago (2014-08-27 11:27:50 UTC) #1
Toon Verwaest
PTAL
6 years, 3 months ago (2014-08-27 11:27:50 UTC) #2
Yang
On 2014/08/27 11:27:50, Toon Verwaest wrote: > PTAL lgtm.
6 years, 3 months ago (2014-08-27 11:31:23 UTC) #3
Toon Verwaest
6 years, 3 months ago (2014-08-27 11:42:23 UTC) #4
Message was sent while issue was closed.
Committed patchset #1 manually as 23452 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698