Issue 514603004: Make WebFrame::isLoading() local-only and map it to load event completion

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 514603004: Make WebFrame::isLoading() local-only and map it to load event completion (Closed)

Created:
6 years, 3 months ago by Nate Chapin

Modified:
6 years, 3 months ago

Reviewers:
abarth-chromium

CC:
abarth-chromium, blink-reviews, dcheng, dglazkov+blink, gavinp+loader_chromium.org, jamesr, Nate Chapin

Base URL:
svn://svn.chromium.org/blink/trunk

Project:
blink

Visibility:
Public.

More Reviews

Description

Make WebFrame::isLoading() local-only and map it to load event completion Also, add isResourceLoadInProgress() for use in content shell, to determine when to complete tests. Exposing this information will allow content shell to better evaluate when to end tests, hopefully eventually leading blink being able to define load completion strictly as the completion of the load event. BUG= Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=181570

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+19 lines, -11 lines)			Patch
M	Source/core/loader/FrameLoader.h	View		1 chunk	+0 lines, -2 lines	0 comments	Download
M	Source/core/loader/FrameLoader.cpp	View	1	1 chunk	+0 lines, -7 lines	0 comments	Download
M	Source/web/WebLocalFrameImpl.h	View	1	1 chunk	+1 line, -0 lines	0 comments	Download
M	Source/web/WebLocalFrameImpl.cpp	View	1	2 chunks	+10 lines, -2 lines	0 comments	Download
M	public/web/WebLocalFrame.h	View	1 2	1 chunk	+8 lines, -0 lines	0 comments	Download

Messages

Total messages: 6 (2 generated)

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/japhet@chromium.org/514603004/40001

6 years, 3 months ago (2014-09-08 17:39:00 UTC) #5

commit-bot: I haz the power

6 years, 3 months ago (2014-09-08 18:27:27 UTC) #6

Message was sent while issue was closed.

Committed patchset #3 (id:40001) as 181570

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages

Issue 514603004: Make WebFrame::isLoading() local-only and map it to load event completion (Closed)

Description

Patch Set 1 #

Patch Set 2 : #

Patch Set 3 : #

Messages